Bugzilla – Attachment 191047 Details for
Bug 41557
LoginFirstname, LoginSurname and emailaddress sent to template but never used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41557: Remove unused vars sent to template
21b965f.patch (text/plain), 1.74 KB, created by
Jonathan Druart
on 2026-01-09 09:27:37 UTC
(
hide
)
Description:
Bug 41557: Remove unused vars sent to template
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-01-09 09:27:37 UTC
Size:
1.74 KB
patch
obsolete
>From 21b965fbdd1ddc290c00c058fd672c8d5f7831c6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 9 Jan 2026 10:26:32 +0100 >Subject: [PATCH] Bug 41557: Remove unused vars sent to template > > 488 LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), > 489 LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", > 490 emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, > >Test plan: >`git grep` the 3 variables and confirm that there is no occurrences in >the templates (.tt/.inc files) >--- > C4/Auth.pm | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 3252f6c4488..f653f1a0f06 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -485,9 +485,6 @@ sub get_template_and_user { > GoogleJackets => C4::Context->preference("GoogleJackets"), > OpenLibraryCovers => C4::Context->preference("OpenLibraryCovers"), > KohaAdminEmailAddress => "" . C4::Context->preference("KohaAdminEmailAddress"), >- LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), >- LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", >- emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, > TagsEnabled => C4::Context->preference("TagsEnabled"), > hide_marc => C4::Context->preference("hide_marc"), > item_level_itypes => C4::Context->preference('item-level_itypes'), >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41557
: 191047