Bugzilla – Attachment 191134 Details for
Bug 41572
Tidy kohaTable block - members
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41572: Tidy kohaTable - members/holdshistory.tt
9373d3e.patch (text/plain), 3.14 KB, created by
Jonathan Druart
on 2026-01-09 14:50:00 UTC
(
hide
)
Description:
Bug 41572: Tidy kohaTable - members/holdshistory.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-01-09 14:50:00 UTC
Size:
3.14 KB
patch
obsolete
>From 9373d3e3812bb575e35451a44e15c91c429a0ff5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 14:08:19 +0100 >Subject: [PATCH] Bug 41572: Tidy kohaTable - members/holdshistory.tt > >--- > .../prog/en/modules/members/holdshistory.tt | 24 ++++++++++--------- > 1 file changed, 13 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >index 3145bc14241..39b689a9ad7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >@@ -181,15 +181,18 @@ > item_types: all_item_types, > libraries: all_libraries, > }; >+ >+ var table_settings = [% TablesSettings.GetTableSettings('members', 'holdshistory', 'holdshistory-table', 'json') | $raw %]; >+ [% UNLESS show_itemtype_column %] >+ //Remove item type column settings >+ table_settings['columns'] = table_settings['columns'].filter(function(c){return c['columnname'] != 'itemtype';}); >+ [% END %] >+ >+ const patron_id = "[% patron.borrowernumber | html %]"; >+ const show_itemtype_column = [% show_itemtype_column ? 1 : 0 | html %]; > </script> > <script> > $(document).ready(function() { >- var table_settings = [% TablesSettings.GetTableSettings('members', 'holdshistory', 'holdshistory-table', 'json') | $raw %]; >- [% UNLESS show_itemtype_column %] >- //Remove item type column settings >- table_settings['columns'] = table_settings['columns'].filter(function(c){return c['columnname'] != 'itemtype';}); >- [% END %] >- > let current_holds_table = build_holds_table("#table_holdshistory"); > let old_holds_table = build_holds_table("#table_oldholdshistory", 1); > function build_holds_table(table_id, old){ >@@ -227,7 +230,7 @@ > > }; > >- let table_url = '/api/v1/patrons/[% patron.borrowernumber | uri %]/holds'; >+ let table_url = `/api/v1/patrons/${patron_id}/holds`; > let table_embeds = ['+strings', 'biblio', 'item', 'pickup_library']; > if (old){ > table_url += '?old=1'; >@@ -323,8 +326,8 @@ > return $date(row.cancellation_date) > } > }, >- [% IF show_itemtype_column %] >- { >+ ...(show_itemtype_column? >+ [{ > data: "item_type_id", > datatype: "coded_value:item_type", > dataFilter: "item_types", >@@ -337,8 +340,7 @@ > return _("Any item type"); > } > } >- }, >- [% END %] >+ ]:[]), > { > data: "status", > searchable: false, >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41572
:
191133
| 191134 |
191135
|
191136
|
191137
|
191138