Bugzilla – Attachment 191158 Details for
Bug 41578
Tidy kohaTable block - serials
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41578: Tidy kohaTable - serials/subscription-detail.tt
1e68ceb.patch (text/plain), 3.09 KB, created by
Jonathan Druart
on 2026-01-09 14:52:41 UTC
(
hide
)
Description:
Bug 41578: Tidy kohaTable - serials/subscription-detail.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-01-09 14:52:41 UTC
Size:
3.09 KB
patch
obsolete
>From 1e68ceb59a40262a220770f7d546866b1bf1f1a3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 14:50:01 +0100 >Subject: [PATCH] Bug 41578: Tidy kohaTable - serials/subscription-detail.tt > >--- > .../en/modules/serials/subscription-detail.tt | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 6d25533f1ad..75d9c547559 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -454,6 +454,13 @@ > [% Asset.js("js/mana.js") | $raw %] > [% INCLUDE 'datatables.inc' %] > [% Asset.js("lib/jquery/plugins/treetable/jquery.treetable.js") | $raw %] >+ >+ <script> >+ var table_settings = [% TablesSettings.GetTableSettings( 'serials', 'subscription-detail', 'orders', 'json' ) | $raw %]; >+ const has_orders = [% orders_grouped.size ? 1 : 0 | html %]; >+ const print_routing_list_issue = "[% print_routing_list_issue | uri %]"; >+ </script> >+ > <script> > // the english words used in display purposes > var text = new Array(_("Number"),_("Volume"),_("Issue"),_("Month"),_("Week"),_("Starting with:"),_("Rollover at:"),_("Choose hemisphere:"),_("Northern"),_("Southern", >@@ -461,11 +468,10 @@ > $(document).ready(function() { > > $("#renewsub").click(function(){ >- popup("[% subscriptionid | html %]"); >+ popup(subscriptionid); > return false; > }) > >- var table_settings = [% TablesSettings.GetTableSettings( 'serials', 'subscription-detail', 'orders', 'json' ) | $raw %]; > var table = $("#orders").kohaTable( > { > columnDefs: [ >@@ -479,7 +485,7 @@ > table_settings > ); > >- [% IF orders_grouped.size %] >+ if (has_orders){ > $(table).treetable({ > expandable: true, > initialState: 'expanded', >@@ -494,8 +500,7 @@ > e.preventDefault(); > $(table).treetable('collapseAll'); > }); >- >- [% END %] >+ } > > let table_dt = table.DataTable(); > $("#hide_received_orders").click(function(e){ >@@ -508,10 +513,10 @@ > }); > $("#show_all_orders").click(); > >- [% IF print_routing_list_issue %] >- var myurl = "/cgi-bin/koha/serials/routing-preview.pl?op=print&subscriptionid=[% subscriptionid | uri %]&issue=[% print_routing_list_issue | uri %]"; >+ if (print_routing_list_issue){ >+ var myurl = `/cgi-bin/koha/serials/routing-preview.pl?op=print&subscriptionid=${subscriptionid}&issue=${print_routing_list_issue}"; > window.open(myurl,'PrintSlip','width=500,height=500,toolbar=no,scrollbars=yes'); >- [% END %] >+ } > > }); > >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41578
:
191155
|
191156
|
191157
| 191158 |
191159
|
191160