Bugzilla – Attachment 19118 Details for
Bug 8836
Resurrect Rotating Collections
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8836 - Resurrect Rotating Collections - QA Followup
Bug-8836---Resurrect-Rotating-Collections---QA-Fol.patch (text/plain), 3.48 KB, created by
Kyle M Hall (khall)
on 2013-06-18 14:46:32 UTC
(
hide
)
Description:
Bug 8836 - Resurrect Rotating Collections - QA Followup
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-06-18 14:46:32 UTC
Size:
3.48 KB
patch
obsolete
>From b8d242ab5f090d42bdc046b9cbfd1585d64a17a9 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 18 Jun 2013 10:34:18 -0400 >Subject: [PATCH] Bug 8836 - Resurrect Rotating Collections - QA Followup > >--- > C4/RotatingCollections.pm | 42 +++++++++++++------------- > rotating_collections/addItems.pl | 4 +-- > rotating_collections/editCollections.pl | 5 +-- > rotating_collections/rotatingCollections.pl | 4 +-- > rotating_collections/transferCollection.pl | 4 +-- > 5 files changed, 26 insertions(+), 33 deletions(-) > >diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm >index d8b94b3..e7506bd 100644 >--- a/C4/RotatingCollections.pm >+++ b/C4/RotatingCollections.pm >@@ -22,10 +22,7 @@ package C4::RotatingCollections; > # with Koha; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > >-use strict; >-#use warnings; FIXME - Bug 2505 >- >-require Exporter; >+use Modern::Perl; > > use C4::Context; > use C4::Circulation; >@@ -47,23 +44,26 @@ C4::RotatingCollections - Functions for managing rotating collections > > =cut > >-@ISA = qw( Exporter ); >-@EXPORT = qw( >- CreateCollection >- UpdateCollection >- DeleteCollection >- >- GetItemsInCollection >+BEGIN { >+ require Exporter; >+ @ISA = qw( Exporter ); >+ @EXPORT = qw( >+ CreateCollection >+ UpdateCollection >+ DeleteCollection > >- GetCollection >- GetCollections >- >- AddItemToCollection >- RemoveItemFromCollection >- TransferCollection >+ GetItemsInCollection > >- GetCollectionItemBranches >-); >+ GetCollection >+ GetCollections >+ >+ AddItemToCollection >+ RemoveItemFromCollection >+ TransferCollection >+ >+ GetCollectionItemBranches >+ ); >+} > > =head2 CreateCollection > ( $success, $errorcode, $errormessage ) = CreateCollection( $title, $description ); >diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl >index 06b6b3a..7302db2 100755 >--- a/rotating_collections/addItems.pl >+++ b/rotating_collections/addItems.pl >@@ -16,9 +16,7 @@ > # Suite 330, Boston, MA 02111-1307 USA > # > >-use strict; >-#use warnings; FIXME - Bug 2505 >-require Exporter; >+use Modern::Perl; > > use C4::Output; > use C4::Auth; >diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl >index e386608..a6e2f8b 100755 >--- a/rotating_collections/editCollections.pl >+++ b/rotating_collections/editCollections.pl >@@ -15,9 +15,8 @@ > # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, > # Suite 330, Boston, MA 02111-1307 USA > # >-use strict; >-#use warnings; FIXME - Bug 2505 >-require Exporter; >+ >+use Modern::Perl; > > use CGI; > >diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl >index 35aea56..d574692 100755 >--- a/rotating_collections/rotatingCollections.pl >+++ b/rotating_collections/rotatingCollections.pl >@@ -16,9 +16,7 @@ > # Suite 330, Boston, MA 02111-1307 USA > # > >-use strict; >-#use warnings; FIXME - Bug 2505 >-require Exporter; >+use Modern::Perl; > > use CGI; > >diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl >index 23eff46..8673b83 100755 >--- a/rotating_collections/transferCollection.pl >+++ b/rotating_collections/transferCollection.pl >@@ -16,9 +16,7 @@ > # Suite 330, Boston, MA 02111-1307 USA > # > >-use strict; >-#use warnings; FIXME - Bug 2505 >-require Exporter; >+use Modern::Perl; > > use C4::Output; > use C4::Auth; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8836
:
12560
|
16746
|
19118
|
19119
|
19337
|
19339
|
21008
|
21009
|
21010
|
21011
|
23966
|
23967
|
23968
|
23969
|
23970
|
23971
|
23976
|
28140
|
28141
|
30838
|
30921
|
31087
|
32361
|
32362
|
32588
|
32589
|
32690
|
32691
|
32693
|
32773
|
32774
|
32973
|
32974
|
32975
|
32976
|
32994
|
32999
|
33000
|
33001
|
33002
|
33045
|
33046
|
33047
|
33048
|
33050
|
33051
|
33058
|
33059
|
33060
|
33061
|
33062
|
33063
|
33064
|
33065
|
33066
|
33068
|
33070
|
33095
|
33096
|
33097
|
33098
|
33099
|
33100
|
33101
|
33102
|
33103
|
33330
|
33331
|
33374