Bugzilla – Attachment 191217 Details for
Bug 41588
Link from 856$u breaks with leading or trailing spaces
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41588: Normalize spaces in 856$u links
Bug-41588-Normalize-spaces-in-856u-links.patch (text/plain), 5.52 KB, created by
Andrew Fuerste-Henry
on 2026-01-09 17:45:10 UTC
(
hide
)
Description:
Bug 41588: Normalize spaces in 856$u links
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2026-01-09 17:45:10 UTC
Size:
5.52 KB
patch
obsolete
>From fd3da779cbd1f1c1bb7d60a0e55aadd483e75394 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Fri, 9 Jan 2026 17:44:13 +0000 >Subject: [PATCH] Bug 41588: Normalize spaces in 856$u links > >To test: >1 - add 856$u " www.cheese.com" to a record >2 - confirm link does not work from results or details in either staff interface or OPAC >3 - add 856$u "www.cheese.com " to a record >4 - confirm link does not work from results or details in either staff interface or OPAC >7 - apply patch, restart_all >8 - reload pages, confirm both links work in results and details in staff interface and OPAC > >Optional final step: have some cheese as a treat >--- > .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- > .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 24c72984123..076aa9edd1a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -973,7 +973,7 @@ > <xsl:with-param name="indicator1" select="@ind1"/> > <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/> > </xsl:call-template> >- <xsl:value-of select="marc:subfield[@code='u']"/> >+ <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/> > </xsl:attribute> > <xsl:choose> > <xsl:when test="($Show856uAsImage='Details' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >index 2b4d8eb9180..5e488366c52 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >@@ -990,7 +990,7 @@ > <xsl:with-param name="indicator1" select="@ind1"/> > <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/> > </xsl:call-template> >- <xsl:value-of select="marc:subfield[@code='u']"/> >+ <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/> > </xsl:attribute> > <xsl:choose> > <xsl:when test="($Show856uAsImage='Results' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index 2d5c76607cc..c4d44a4234c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -1087,7 +1087,7 @@ > <xsl:with-param name="indicator1" select="@ind1"/> > <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/> > </xsl:call-template> >- <xsl:value-of select="marc:subfield[@code='u']"/> >+ <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/> > </xsl:attribute> > </xsl:otherwise> > </xsl:choose> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index 9da8f22543c..b4b8c7dc2e1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -1209,7 +1209,7 @@ > <xsl:with-param name="indicator1" select="@ind1"/> > <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/> > </xsl:call-template> >- <xsl:value-of select="marc:subfield[@code='u']"/> >+ <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/> > </xsl:attribute> > </xsl:otherwise> > </xsl:choose> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41588
:
191217
|
191218