Bugzilla – Attachment 191226 Details for
Bug 35211
Make it possible to split holdings tab using library groups in intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35211: Move other_holdings_count outside of loop so it is only calculated once
Bug-35211-Move-otherholdingscount-outside-of-loop-.patch (text/plain), 1.09 KB, created by
Lucas Gass (lukeg)
on 2026-01-09 20:48:30 UTC
(
hide
)
Description:
Bug 35211: Move other_holdings_count outside of loop so it is only calculated once
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-01-09 20:48:30 UTC
Size:
1.09 KB
patch
obsolete
>From 13db3275a16e4cd910cc6bb6a23c367dad7564b0 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 9 Jan 2026 20:47:53 +0000 >Subject: [PATCH] Bug 35211: Move other_holdings_count outside of loop so it is > only calculated once > >--- > catalogue/detail.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index caec6916630..f7a2f00c348 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -381,11 +381,13 @@ if ( C4::Context->preference('SeparateHoldingsByGroup') ) { > $total_group_holdings_count += $group_holdings_count; > > push @lib_groups, $group; >- $other_holdings_count = ( $items_to_display->count ) - $total_group_holdings_count; > } > } > } > >+ #only need to calculate the other_holdings_count once >+ $other_holdings_count = ( $items_to_display->count ) - $total_group_holdings_count; >+ > $template->param( > lib_groups => \@lib_groups, > branchcode_hash => \%branchcode_hash, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35211
:
183075
|
183099
|
183143
|
183144
|
183420
|
183615
|
183642
|
183643
|
183901
|
183945
|
183949
|
183950
|
183966
|
183967
|
183968
|
184016
|
185336
|
185515
|
185525
|
185526
|
185527
|
185528
|
185529
|
185530
|
185531
|
188553
|
188554
|
188555
|
188556
|
188557
|
188558
|
188559
|
189379
|
189442
|
189443
|
189444
|
189445
|
189446
|
189447
|
189448
|
189449
|
189450
|
189451
|
191225
|
191226
|
191230
|
191231