Bugzilla – Attachment 191229 Details for
Bug 41560
Useless (and confusing) id attribute on a couple of script tag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41560: Remove id="js" from script tags
346d52d.patch (text/plain), 2.33 KB, created by
David Nind
on 2026-01-09 21:27:18 UTC
(
hide
)
Description:
Bug 41560: Remove id="js" from script tags
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-01-09 21:27:18 UTC
Size:
2.33 KB
patch
obsolete
>From 346d52d6471218f472d06a9e88aa53349bc265d8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 11:42:53 +0100 >Subject: [PATCH] Bug 41560: Remove id="js" from script tags > >Both files > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt > koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt > >have > <script id="js"> > >That's not needed, useless, and confusing. > >Added from those commits for no obvious reasons >catalogue/issuehistory.tt >commit df98c8aaaaf0a7406dc24f4c288c8f930aa8215d >CommitDate: Mon May 14 15:39:44 2012 +0200 > bug_7647: Table sorter on issue history > >members/readingrec.tt >commit 77b6409802e6ce5612883ec6d22db9545547444a >CommitDate: Mon Mar 21 20:02:15 2011 +1300 > Bug 5917 : Converted templates >--- > .../intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >index 409f57721b..780342c4ff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >@@ -127,7 +127,7 @@ > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] >- <script id="js"> >+ <script> > $(document).ready(function() { > var table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'checkoutshistory-table', 'json') | $raw %]; > [% UNLESS show_patron_column %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 746a13ceae..5fb5dde1c9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -163,7 +163,7 @@ > [% INCLUDE 'modals/checkout_renewals.inc' %] > [% INCLUDE 'js-date-format.inc' %] > [% Asset.js("js/checkout_renewals_modal.js") | $raw %] >- <script id="js"> >+ <script> > $(document).ready(function() { > [% IF Koha.Preference('RecordStaffUserOnCheckout') %] > // FIXME This cannot work without bKohaColumnsUseNames >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41560
:
191060
| 191229