Bugzilla – Attachment 191333 Details for
Bug 41599
reports/acquisitions_stats.pl calls output_error incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41599: Fix output_error in acquisitions_stats.pl
Bug-41599-Fix-outputerror-in-acquisitionsstatspl.patch (text/plain), 1.28 KB, created by
David Cook
on 2026-01-13 02:15:21 UTC
(
hide
)
Description:
Bug 41599: Fix output_error in acquisitions_stats.pl
Filename:
MIME Type:
Creator:
David Cook
Created:
2026-01-13 02:15:21 UTC
Size:
1.28 KB
patch
obsolete
>From 6fd17294a5092d506a5336916e6cde27940d7272 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 13 Jan 2026 02:12:03 +0000 >Subject: [PATCH] Bug 41599: Fix output_error in acquisitions_stats.pl > >This patch changes the incorrect usage of output_error >in acquisitions_stats.pl so that it uses a HTTP status >code instead of an arbitrary string. > >Test plan: >0. Apply the patch and koha-plack --restart kohadev >1. Go to http://localhost:8081/cgi-bin/koha/reports/acquisitions_stats.pl >2. Use your F12 HTML inspector to find the "Line" radio buttons that you've >selected and remove the values for those elements >3. Click "Submit" at the bottom of the screen >4. Note that you get a 403 error (if bug 30803 applied - otherwise it's a 404 error) >--- > reports/acquisitions_stats.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index bb3c4ccf780..e5effc95c24 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -69,7 +69,7 @@ if ( > || $column !~ /^(aqbasket|aqorders|aqbooksellers|items|biblioitems|aqbudgets)\.\w+$/ ) > ) > { >- C4::Output::output_error( $input, 'Possible SQL injection' ); >+ C4::Output::output_error( $input, '403' ); > exit; > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41599
:
191333
|
191342