Bugzilla – Attachment 191340 Details for
Bug 30803
output_error should not assume a 404 status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30803: Add tests
389aa7f.patch (text/plain), 1.69 KB, created by
Jonathan Druart
on 2026-01-13 09:14:31 UTC
(
hide
)
Description:
Bug 30803: Add tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-01-13 09:14:31 UTC
Size:
1.69 KB
patch
obsolete
>From 389aa7ffc89c500a6ec7d428a1af9c1080ffe915 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 13 Jan 2026 10:08:11 +0100 >Subject: [PATCH] Bug 30803: Add tests > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/Output.t | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > >diff --git a/t/Output.t b/t/Output.t >index a7356bdffba..3c022a3fab2 100755 >--- a/t/Output.t >+++ b/t/Output.t >@@ -18,7 +18,7 @@ > use Modern::Perl; > > use Test::NoWarnings; >-use Test::More tests => 9; >+use Test::More tests => 10; > use Test::Warn; > use Test::MockModule; > >@@ -30,7 +30,7 @@ use C4::Auth qw( get_template_and_user ); > use t::lib::Mocks; > > BEGIN { >- use_ok( 'C4::Output', qw( output_html_with_http_headers output_and_exit_if_error parametrized_url ) ); >+ use_ok( 'C4::Output', qw( output_html_with_http_headers output_and_exit_if_error output_error parametrized_url ) ); > } > > our $output_module = Test::MockModule->new('C4::Output'); >@@ -137,3 +137,25 @@ subtest 'output_and_exit_if_error() tests' => sub { > # Next call triggers test in the mocked sub > output_and_exit_if_error( $query, $cookie, $template, { check => 'csrf_token' } ); > }; >+ >+subtest 'output_error' => sub { >+ plan tests => 2; >+ >+ local *STDOUT; >+ my $stdout; >+ >+ my $query = CGI->new(); >+ my $cookie; >+ my $output = 'foobarbaz'; >+ >+ open STDOUT, '>', \$stdout; >+ output_error( $query, "404" ); >+ like( $stdout, qr{Error 404}, '404 returned' ); >+ close STDOUT; >+ >+ open STDOUT, '>', \$stdout; >+ output_error( $query, "403" ); >+ like( $stdout, qr{Error 403}, '403 returned' ); >+ close STDOUT; >+ >+}; >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30803
:
191332
|
191339
| 191340 |
191341