Bugzilla – Attachment 191362 Details for
Bug 41567
Tidy kohaTable block - cataloguing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41567: Tidy kohaTable - cataloguing/addbooks.tt
Bug-41567-Tidy-kohaTable---cataloguingaddbookstt.patch (text/plain), 4.08 KB, created by
Owen Leonard
on 2026-01-13 14:29:02 UTC
(
hide
)
Description:
Bug 41567: Tidy kohaTable - cataloguing/addbooks.tt
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-13 14:29:02 UTC
Size:
4.08 KB
patch
obsolete
>From 7319fc2c8d7c165aeff0fa718a9675dec2aab41f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 11:52:31 +0100 >Subject: [PATCH] Bug 41567: Tidy kohaTable - cataloguing/addbooks.tt > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/cataloguing/addbooks.tt | 34 ++++++++++++------- > 1 file changed, 22 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index 17173ad1dab..e8263ba12c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -323,6 +323,14 @@ > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] >+ <script> >+ var table_settings = [% TablesSettings.GetTableSettings( 'cataloguing', 'addbooks', 'reservoir-table', 'json' ) | $raw %] >+ const interface = "[% interface | html %]"; >+ const theme = "[% theme | html %]"; >+ const biblionumber = "[% biblionumber | html %]"; >+ var logged_in_user_borrowernumber = "[% logged_in_user.borrowernumber | html %]"; >+ </script> >+ > <script> > $(document).ready(function() { > //Set focus to cataloging search >@@ -349,7 +357,7 @@ > }); > > $("#useadvanced").click(function(){ >- Cookies.set( "catalogue_editor_[% logged_in_user.borrowernumber | html %]", "advanced", { expires: 365, path: '/', sameSite: 'Lax' } ); >+ Cookies.set( `catalogue_editor_${logged_in_user_borrowernumber}`, "advanced", { expires: 365, path: '/', sameSite: 'Lax' } ); > return true; > }); > >@@ -363,10 +371,9 @@ > }); > $("#dataPreview").on("hidden.bs.modal", function(){ > $("#dataPreviewLabel").html(""); >- $("#dataPreview .modal-body").html("<div id=\"loading\"><img src=\"[% interface | html %]/[% theme | html %]/img/spinner-small.gif\" alt=\"\" /> "+_("Loading")+"</div>"); >+ $("#dataPreview .modal-body").html("<div id=\"loading\"><img src=\"" + interface + "/" + theme + "/img/spinner-small.gif\" alt=\"\" /> "+_("Loading")+"</div>"); > }); > >- var table_settings = [% TablesSettings.GetTableSettings( 'cataloguing', 'addbooks', 'reservoir-table', 'json' ) | $raw %] > var reservoirt = $("#reservoir-table").kohaTable( > { > pagingType: "simple", >@@ -379,17 +386,9 @@ > function PopupZ3950(fw) { > var strQuery = GetZ3950Terms(fw); > if(strQuery){ >- window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); >+ window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" + biblionumber + strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); > } > } >- /* provide Z3950 search points */ >- function GetZ3950Terms(fw){ >- var strQuery="&frameworkcode=" + fw; >- [% FOREACH z3950_search_param IN z3950_search_params %] >- strQuery += "&" + "[% z3950_search_param.name | uri %]" + "=" + "[% z3950_search_param.value | uri %]"; >- [% END %] >- return strQuery; >- } > > /** > * This function checks if the adequate number of records are checked for merging >@@ -409,6 +408,17 @@ > return false; > } > </script> >+ >+ <script> >+ /* provide Z3950 search points */ >+ function GetZ3950Terms(fw){ >+ var strQuery="&frameworkcode=" + fw; >+ [% FOREACH z3950_search_param IN z3950_search_params %] >+ strQuery += "&" + "[% z3950_search_param.name | uri %]" + "=" + "[% z3950_search_param.value | uri %]"; >+ [% END %] >+ return strQuery; >+ } >+ </script> > [% END %] > > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41567
:
191107
|
191108
|
191109
|
191110
| 191362 |
191363
|
191364
|
191365