Bugzilla – Attachment 191372 Details for
Bug 38262
Add additional fields to vendors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38262: (follow-up) Check for extended attributes before iterating
Bug-38262-follow-up-Check-for-extended-attributes-.patch (text/plain), 1.61 KB, created by
Lucas Gass (lukeg)
on 2026-01-13 16:54:09 UTC
(
hide
)
Description:
Bug 38262: (follow-up) Check for extended attributes before iterating
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-01-13 16:54:09 UTC
Size:
1.61 KB
patch
obsolete
>From 4bdfc88d2241f6992f1601e280b51fa39d64f4f5 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Tue, 13 Jan 2026 16:30:10 +0000 >Subject: [PATCH] Bug 38262: (follow-up) Check for extended attributes before > iterating > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > Koha/REST/V1/Acquisitions/Vendors.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/REST/V1/Acquisitions/Vendors.pm b/Koha/REST/V1/Acquisitions/Vendors.pm >index 33037121abd..3e7a727c019 100644 >--- a/Koha/REST/V1/Acquisitions/Vendors.pm >+++ b/Koha/REST/V1/Acquisitions/Vendors.pm >@@ -114,7 +114,7 @@ sub add { > $vendor_to_store->aliases( $aliases || [] ); > $vendor_to_store->interfaces( $interfaces || [] ); > >- if ( scalar(@$extended_attributes) > 0 ) { >+ if ( $extended_attributes && scalar(@$extended_attributes) > 0 ) { > my @extended_attributes = > map { { 'id' => $_->{field_id}, 'value' => $_->{value} } } @{$extended_attributes}; > $vendor_to_store->extended_attributes( \@extended_attributes ); >@@ -160,7 +160,7 @@ sub update { > $vendor->aliases( $aliases || [] ) if defined $aliases; > $vendor->interfaces( $interfaces || [] ) if defined $interfaces; > >- if ( scalar(@$extended_attributes) > 0 ) { >+ if ( $extended_attributes && scalar(@$extended_attributes) > 0 ) { > my @extended_attributes = > map { { 'id' => $_->{field_id}, 'value' => $_->{value} } } @{$extended_attributes}; > $vendor->extended_attributes( \@extended_attributes ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38262
:
175147
|
175148
|
175149
|
175712
|
175713
|
175714
|
180558
|
180559
|
180560
|
182602
|
182603
|
182604
|
183026
|
183027
|
183028
|
183029
|
183030
|
183031
|
188213
|
188214
|
188215
|
188364
|
188366
|
188377
|
188384
|
188385
|
188386
|
188388
|
188754
|
188755
|
188756
|
189024
|
189025
|
189026
|
189157
|
189166
|
189167
|
189168
|
189169
|
191370
| 191372 |
191396