Bugzilla – Attachment 191408 Details for
Bug 41571
Tidy kohaTable block - labels
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41571: (follow-up) Remove unused function
Bug-41571-follow-up-Remove-unused-function.patch (text/plain), 3.18 KB, created by
Owen Leonard
on 2026-01-14 12:57:15 UTC
(
hide
)
Description:
Bug 41571: (follow-up) Remove unused function
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-14 12:57:15 UTC
Size:
3.18 KB
patch
obsolete
>From a8e427bc5aada49425e6a115c69388170a9469ef Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 14 Jan 2026 07:35:49 -0500 >Subject: [PATCH] Bug 41571: (follow-up) Remove unused function > >The selected_layout function is defined but never called. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../en/modules/labels/label-edit-batch.tt | 16 ------------ > .../prog/en/modules/labels/label-manage.tt | 25 +------------------ > 2 files changed, 1 insertion(+), 40 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >index 5a5e6d7572c..413b8308a25 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >@@ -327,22 +327,6 @@ > } > } > >- function selected_layout() { >- if (document.items.action.length) { >- for (i=0;i<document.items.action.length;i++){ >- if (document.items.action[i].checked==true){ >- return(document.items.action[i].value); >- } >- } >- } else { >- if (document.items.action.checked){ >- return(document.items.action.value); >- } >- } >- alert(_("Please select at least one item.")); >- return (-1); >- } >- > $(document).ready(function() { > $('.sidebar_menu a[href$="/cgi-bin/koha/labels/label-home.pl"]').addClass("current"); > if (has_entries){ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >index 1284f16580e..5233dce25c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >@@ -181,30 +181,7 @@ > } > location.href = "/cgi-bin/koha/labels/label-print.pl?" + getstr; > } >- function selected_layout(op) { >- var selected = new Array; >- if (document.layouts.action.length) { >- for (i=0;i<document.layouts.action.length;i++){ >- if (document.layouts.action[i].checked){ >- selected.push(i); >- } >- }; >- if (selected.length == 1) { >- return(document.layouts.action[selected[0]].value); >- } >- else { >- alert(_("Please select only one %s to %s.").format("[% label_element | html %]", op)); >- return (-1); >- } >- } >- else { >- if (document.layouts.action.checked){ >- return(document.layouts.action.value); >- } >- }; >- alert(_("Please select a %s.").format("[% label_element | html %]")); >- return (-1); >- } >+ > $(document).ready(function(){ > $('.sidebar_menu a[href$="/cgi-bin/koha/labels/label-home.pl"]').addClass("current"); > $("#print").click(function(e){ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41571
:
191130
|
191131
|
191132
|
191407
| 191408 |
191409