Bugzilla – Attachment 191471 Details for
Bug 41624
Improvements to Bug 35211
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41624: Move other_holdings_count outside of loop so it is only calculated once
Bug-41624-Move-otherholdingscount-outside-of-loop-.patch (text/plain), 1.08 KB, created by
Lucas Gass (lukeg)
on 2026-01-14 21:51:32 UTC
(
hide
)
Description:
Bug 41624: Move other_holdings_count outside of loop so it is only calculated once
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-01-14 21:51:32 UTC
Size:
1.08 KB
patch
obsolete
>From 791136ea642255c9310d0b6084d30a958f559336 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 9 Jan 2026 20:47:53 +0000 >Subject: [PATCH] Bug 41624: Move other_holdings_count outside of loop so it is > only calculated once > >--- > catalogue/detail.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index eca6dce2ce2..1f3204ecd37 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -383,11 +383,13 @@ if ( C4::Context->preference('SeparateHoldingsByGroup') ) { > $total_group_holdings_count += $group_holdings_count; > > push @lib_groups, $group; >- $other_holdings_count = ( $items_to_display->count ) - $total_group_holdings_count; > } > } > } > >+ #only need to calculate the other_holdings_count once >+ $other_holdings_count = ( $items_to_display->count ) - $total_group_holdings_count; >+ > $template->param( > lib_groups => \@lib_groups, > holdings_count_hash => \%holdings_count, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41624
:
191470
| 191471