Bugzilla – Attachment 191564 Details for
Bug 40905
Past unique holidays not shown when enabling Show past checkbox
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40905: (QA follow-up) Apply same fix for exceptions table
Bug-40905-QA-follow-up-Apply-same-fix-for-exceptio.patch (text/plain), 1.91 KB, created by
Nick Clemens (kidclamp)
on 2026-01-16 13:45:59 UTC
(
hide
)
Description:
Bug 40905: (QA follow-up) Apply same fix for exceptions table
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2026-01-16 13:45:59 UTC
Size:
1.91 KB
patch
obsolete
>From 6cb61d210fda853750d0406614fa0abf6c6fbca2 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 16 Jan 2026 13:42:24 +0000 >Subject: [PATCH] Bug 40905: (QA follow-up) Apply same fix for exceptions table > >This table also has a show past holidays button, we need the same fix > >To test: >1 - Spam holidays into both tables > You can run the SQL commands below a few times each >INSERT INTO special_holidays (branchcode, day, month, year,isexception, title,description) VALUES ('CPL',FLOOR(RAND() * 28) + 1,FLOOR(RAND() * 12) + 1,FLOOR(RAND() * 6) + 2020,0,LEFT(UUID(),8),UUID()); > >INSERT INTO special_holidays (branchcode, day, month, year,isexception, title,description) VALUES ('CPL',FLOOR(RAND() * 28) + 1,FLOOR(RAND() * 12) + 1,FLOOR(RAND() * 6) + 2020,1,LEFT(UUID(),8),UUID()); > >2 - Go to Tools->Calendar >3 - Click 'Show past holidays' for exceptions and unique holidays >4 - Confirm checking and unchecking work on both tables > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt >index 2105fbdd9a0..bfd0e3e50a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt >@@ -631,9 +631,11 @@ > $("#holidaysyearlyrepeatable").kohaTable(dt_params); > $("#holidaysunique").kohaTable(dt_params); > >- let unique_table = $("#holidaysunique").DataTable(); >+ let exceptions_table = $("#holidayexceptions").DataTable(); >+ let unique_table = $("#holidaysunique").DataTable(); > > $(".show_past").on("change", function(){ >+ exceptions_table.draw(); > unique_table.draw(); > }); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40905
:
187094
|
190936
|
191563
| 191564