Bugzilla – Attachment 191590 Details for
Bug 41578
Tidy kohaTable block - serials
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41578: (follow-up) More tidying
Bug-41578-follow-up-More-tidying.patch (text/plain), 4.36 KB, created by
Owen Leonard
on 2026-01-16 18:22:42 UTC
(
hide
)
Description:
Bug 41578: (follow-up) More tidying
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-16 18:22:42 UTC
Size:
4.36 KB
patch
obsolete
>From ea4d495d7fdf3504a54aa0fca85f3179f6d265e6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 16 Jan 2026 13:20:13 -0500 >Subject: [PATCH] Bug 41578: (follow-up) More tidying > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../en/modules/serials/subscription-detail.tt | 56 ++++++++++++------- > 1 file changed, 35 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 44be4fe1296..3bcaa38daa3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -461,14 +461,29 @@ > </script> > <script> > // the english words used in display purposes >- var text = new Array(_("Number"),_("Volume"),_("Issue"),_("Month"),_("Week"),_("Starting with:"),_("Rollover at:"),_("Choose hemisphere:"),_("Northern"),_("Southern", >- "Autumn"),_("Winter"),_("Spring"),_("Summer"),_("Fall"),_("Season"),_("Year")); >- $(document).ready(function() { >- >- $("#renewsub").click(function(){ >+ var text = new Array( >+ _("Number"), >+ _("Volume"), >+ _("Issue"), >+ _("Month"), >+ _("Week"), >+ _("Starting with:"), >+ _("Rollover at:"), >+ _("Choose hemisphere:"), >+ _("Northern"), >+ _("Southern", "Autumn"), >+ _("Winter"), >+ _("Spring"), >+ _("Summer"), >+ _("Fall"), >+ _("Season"), >+ _("Year") >+ ); >+ $(document).ready(function () { >+ $("#renewsub").click(function () { > popup(subscriptionid); > return false; >- }) >+ }); > > var table = $("#orders").kohaTable( > { >@@ -483,42 +498,41 @@ > table_settings > ); > >- if (has_orders){ >+ if (has_orders) { > $(table).treetable({ > expandable: true, >- initialState: 'expanded', >+ initialState: "expanded", > }); >- $(table).treetable('expandAll'); >+ $(table).treetable("expandAll"); > >- $("#expand_all").click(function(e){ >+ $("#expand_all").click(function (e) { > e.preventDefault(); >- $(table).treetable('expandAll'); >+ $(table).treetable("expandAll"); > }); >- $("#collapse_all").click(function(e){ >+ $("#collapse_all").click(function (e) { > e.preventDefault(); >- $(table).treetable('collapseAll'); >+ $(table).treetable("collapseAll"); > }); > } > > let table_dt = table.DataTable(); >- $("#hide_received_orders").click(function(e){ >+ $("#hide_received_orders").click(function (e) { > e.preventDefault(); >- table_dt.columns(4).search('^$', {regex: true}).draw(); // Not empty "Receive date" columns >+ table_dt.columns(4).search("^$", { regex: true }).draw(); // Not empty "Receive date" columns > }); >- $("#show_all_orders").click(function(e){ >+ $("#show_all_orders").click(function (e) { > e.preventDefault(); >- table_dt.columns(4).search('').draw(); // Not filter, display all columns >+ table_dt.columns(4).search("").draw(); // Not filter, display all columns > }); > $("#show_all_orders").click(); > >- if (print_routing_list_issue){ >+ if (print_routing_list_issue) { > var myurl = `/cgi-bin/koha/serials/routing-preview.pl?op=print&subscriptionid=${subscriptionid}&issue=${print_routing_list_issue}`; >- window.open(myurl,'PrintSlip','width=500,height=500,toolbar=no,scrollbars=yes'); >+ window.open(myurl, "PrintSlip", "width=500,height=500,toolbar=no,scrollbars=yes"); > } >- > }); > >- function mana_comment_close(){ >+ function mana_comment_close() { > $("#selected_id").val(""); > $("#mana-resource-id").val(""); > $("#mana-comment").val(""); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41578
:
191155
|
191156
|
191157
|
191158
|
191159
|
191160
|
191583
|
191584
|
191585
|
191586
|
191587
|
191588
|
191589
| 191590