Bugzilla – Attachment 191698 Details for
Bug 41580
Tidy kohaTable block - tools
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt
Bug-41580-Tidy-kohaTable---toolsbatchmodifyholdstt.patch (text/plain), 2.57 KB, created by
Owen Leonard
on 2026-01-20 15:25:52 UTC
(
hide
)
Description:
Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-20 15:25:52 UTC
Size:
2.57 KB
patch
obsolete
>From f2c6b3a880230feeb09a9b55aae841b269cbcc2a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 15:49:25 +0100 >Subject: [PATCH] Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/tools/batch_modify_holds.tt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >index de32ade2238..2101a52f109 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >@@ -249,7 +249,11 @@ > let hide_patron_name = [% IF Koha.Preference('HidePatronName') %]true[% ELSE %]false[% END %]; > let hold_ids = [% IF updated_holds %] [% updated_holds | $raw %] [% ELSE %] [] [% END %]; > let hold_ids_from_sql = [% IF reserve_ids_list %] [% reserve_ids_list | $raw %] [% ELSE %] [] [% END %]; >+ var holds_to_modify_table_settings = [% TablesSettings.GetTableSettings( 'tools', 'batch_hold_modification', 'holds_to_modify', 'json' ) | $raw %]; >+ var modified_holds_table_settings = [% TablesSettings.GetTableSettings( 'circ', 'holds', 'modified_holds', 'json' ) | $raw %]; >+ </script> > >+ <script> > $(document).ready(function() { > > // Apply select2 to all select fields having a "multiple" attribute >@@ -343,7 +347,6 @@ > } > > function search_holds(modify_holds_form){ >- var table_settings = [% TablesSettings.GetTableSettings( 'tools', 'batch_hold_modification', 'holds_to_modify', 'json' ) | $raw %]; > var searchpattern = ""; > var filters = { > "me.expirationdate": function(){ >@@ -570,7 +573,7 @@ > } > } > ], >- }, table_settings, 0, filters); >+ }, holds_to_modify_table_settings, 0, filters); > > $(".searchpattern").text(searchpattern); > >@@ -643,11 +646,10 @@ > }); > > //Modified holds table >- var table_settings = [% TablesSettings.GetTableSettings( 'circ', 'holds', 'modified_holds', 'json' ) | $raw %]; > $("#modified_holds").kohaTable({ > pagingType: "full", > autoWidth: false >- }, table_settings); >+ }, modified_holds_table_settings); > > }); > </script> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41580
:
191163
|
191164
|
191165
|
191166
|
191167
|
191168
|
191169
|
191170
|
191171
|
191697
| 191698 |
191699
|
191700
|
191701
|
191702
|
191703
|
191704
|
191705
|
191706
|
191707