Bugzilla – Attachment 191780 Details for
Bug 38643
Advanced Search input fields need placeholders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38643: (QA follow-up) Replace _() with __() in global.js
Bug-38643-QA-follow-up-Replace--with--in-globaljs.patch (text/plain), 1.18 KB, created by
Nick Clemens (kidclamp)
on 2026-01-21 14:23:32 UTC
(
hide
)
Description:
Bug 38643: (QA follow-up) Replace _() with __() in global.js
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2026-01-21 14:23:32 UTC
Size:
1.18 KB
patch
obsolete
>From 8600df53618323043fce133ef8131535e74d0b90 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Jan 2026 08:28:35 -0500 >Subject: [PATCH] Bug 38643: (QA follow-up) Replace _() with __() in global.js > >The double-underscore function is required for translations to be picked >up in JS files. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/js/global.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/global.js b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >index 1c980d7d405..73044012988 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/global.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >@@ -270,7 +270,7 @@ function setAdvancedPlaceholder(selectEl) { > var $row = $select.closest(".search-term-row"); > var $input = $row.find("input[name='q']"); > var ph = $select.find("option:selected").data("placeholder"); >- $input.attr("placeholder", ph || _("Enter search terms")); >+ $input.attr("placeholder", ph || __("Enter search terms")); > } > > $(".advanced-search-terms select[name='idx']").each(function () { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38643
:
185940
|
185941
|
186248
|
191488
|
191489
|
191490
|
191778
|
191779
| 191780