Bugzilla – Attachment 191807 Details for
Bug 35237
Duplicate ids in markup of patron card layout edit form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35237: Changed labels above checkbox on the edit layout page.
Bug-35237-Changed-labels-above-checkbox-on-the-edi.patch (text/plain), 3.30 KB, created by
Owen Leonard
on 2026-01-21 17:55:29 UTC
(
hide
)
Description:
Bug 35237: Changed labels above checkbox on the edit layout page.
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-01-21 17:55:29 UTC
Size:
3.30 KB
patch
obsolete
>From 07f80ed2a8b7ca057fd9651f52d54af7c8c58c0e Mon Sep 17 00:00:00 2001 >From: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> >Date: Wed, 21 Jan 2026 01:47:36 +0000 >Subject: [PATCH] Bug 35237: Changed labels above checkbox on the edit layout > page. > >Clarified the for attribute for the original labels of the checkboxes. > >Test plan: >1. Head to 'tools' then 'patron card creator' >2. Click on 'Layouts' underneath 'Manage' >3. Click on 'Edit' >4. Confirm it's easy to tell which options are available and chosen for > page side, guide box, and guide grid >5. Inspect the page, look at and confirm the original labels have been > renamed for page size, guide box, guide grid > >Sponsored-by: Catalyst IT >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/patroncards/edit-layout.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >index e227d8fe8ef..a10d1e0f4dc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >@@ -80,7 +80,7 @@ > </select> > </li> > <li> >- <label for="page_side_front">Page side: </label> >+ <label for="page_side">Page side: </label> > [% IF ( page_side ) %] > <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" /></label> > <label for="page_side_back">Back: <input type="radio" name="page_side" id="page_side_back" value="B" checked="checked" /></label> >@@ -90,7 +90,7 @@ > [% END %] > </li> > <li> >- <label for="guide_box_on">Guide box:</label> >+ <label for="guide_box">Guide box:</label> > [% IF ( guide_box ) %] > <label for="guide_box_on">On: <input type="radio" name="guide_box" id="guide_box_on" value="0" /></label> > <label for="guide_box_off">Off: <input type="radio" name="guide_box" id="guide_box_off" value="1" checked="checked" /></label> >@@ -100,7 +100,7 @@ > [% END %] > </li> > <li> >- <label for="guide_grid_off">Guide grid:</label> >+ <label for="guide_grid">Guide grid:</label> > [% IF ( guide_grid ) %] > <label for="guide_grid_on">On: <input type="radio" name="guide_grid" id="guide_grid_on" value="1" checked="checked" /></label> > <label for="guide_grid_off">Off: <input type="radio" name="guide_grid" id="guide_grid_off" value="0" /></label> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35237
:
184253
|
184421
|
186246
|
191736
|
191806
| 191807 |
191808