Bugzilla – Attachment 191836 Details for
Bug 41497
ul.patronbriefinfo inconsistent in coding structure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41497: ul.patronbriefinfo inconsistent in coding structure
Bug-41497-ulpatronbriefinfo-inconsistent-in-coding.patch (text/plain), 4.32 KB, created by
Katrin Fischer
on 2026-01-21 21:19:32 UTC
(
hide
)
Description:
Bug 41497: ul.patronbriefinfo inconsistent in coding structure
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2026-01-21 21:19:32 UTC
Size:
4.32 KB
patch
obsolete
>From ec69ea9e9c0848df27c1ca15f98d8cb5a19deb7c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 5 Jan 2026 09:12:31 -0500 >Subject: [PATCH] Bug 41497: ul.patronbriefinfo inconsistent in coding > structure > >This patch updates the markup of the include which displays patron >information on the checkout and patron detail pages. The changes are >minor and should have no visible effect. > >To test, apply the patch and search for a patron in the staff interface. > >View the patron information in the sidebar on both the checkout and >patron detail pages. Everything should look correct. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Manvi <manvisharma1006@gmail.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/includes/circ-menu.inc | 22 +++++++------------ > 1 file changed, 8 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 6f9909c0c46..7ce31a2157b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -112,19 +112,19 @@ > [% END %] > > [% UNLESS ( patron.address or patron.address2 ) %] >- <li><span class="empty" id="noaddressstored">No address stored.</span></li> >+ <li class="empty"><span id="noaddressstored">No address stored.</span></li> > [% END %] > [% UNLESS ( patron.city ) %] >- <li><span class="empty" id="nocitystored">No city stored.</span></li> >+ <li class="empty"><span id="nocitystored">No city stored.</span></li> > [% END %] > [% UNLESS ( patron.phone or patron.mobile or patron.phonepro) %] >- <li> <span class="empty">No phone stored.</span></li> >+ <li class="empty"><span>No phone stored.</span></li> > [% END %] > [% UNLESS ( patron.email or patron.emailpro) %] >- <li> <span class="empty">No email stored.</span></li> >+ <li class="empty"><span>No email stored.</span></li> > [% END %] > [% UNLESS ( patron.dateofbirth ) %] >- <li> <span class="empty">No date of birth stored.</span></li> >+ <li class="empty"><span>No date of birth stored.</span></li> > [% END %] > [% END # /IF HidePersonalPatronDetailOnCirculation %] > >@@ -150,18 +150,12 @@ > <li class="patroncategory"> Category: <span class="patroncategory_description">[% patron.category.description | html %]</span> <span class="patroncategory_code">([% patron.categorycode | html %])</span> </li> > <li class="patronlibrary"> Home library: [% Branches.GetName( patron.branchcode ) | html %] </li> > <li class="patronborrowernumber"> Borrowernumber: [% patron.borrowernumber | html %] </li> >- <li> >- <span class="patronupdatedon">Updated on: [% patron.updated_on | $KohaDates with_hours => 1 %]</span> >- </li> >+ <li class="patronupdatedon">Updated on: [% patron.updated_on | $KohaDates with_hours => 1 %]</li> > [% IF Koha.Preference('TrackLastPatronActivityTriggers') %] > [% IF ( patron.lastseen ) %] >- <li> >- <span class="patronlastseenon">Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %]</span> >- </li> >+ <li class="patronlastseenon"> Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %] </li> > [% ELSE %] >- <li> >- <span class="patronlastseenon">Last seen on: not recorded</span> >- </li> >+ <li class="patronlastseenon"> Last seen on: not recorded </li> > [% END %] > [% END %] > [% IF patron.account_locked %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41497
:
190896
|
191830
| 191836