Bugzilla – Attachment 191871 Details for
Bug 41688
Refund modal and amount as NaN, rejected comma separator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41688: Fix NaN display in POS refund modal
Bug-41688-Fix-NaN-display-in-POS-refund-modal.patch (text/plain), 6.35 KB, created by
Thibaud Guillot (thibaud_g)
on 2026-01-22 15:54:53 UTC
(
hide
)
Description:
Bug 41688: Fix NaN display in POS refund modal
Filename:
MIME Type:
Creator:
Thibaud Guillot (thibaud_g)
Created:
2026-01-22 15:54:53 UTC
Size:
6.35 KB
patch
obsolete
>From 242ff4c9b795e7d768648f74e5c5b933475b73d4 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Thu, 22 Jan 2026 16:47:14 +0100 >Subject: [PATCH] Bug 41688: Fix NaN display in POS refund modal > >Test plan: > >Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) > >1. Go to POS > register > transaction history >2. Click "Issue refund" on any paid transaction >3. Verify "Amount paid" shows correct amount (not NaN) >4. Enter refund amount with comma decimal (e.g. 5,50) >5. Verify no validation error occurs >6. Process refund successfully >--- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index 828ac21e6d..059fefdf43 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -125,9 +125,9 @@ > <td></td> > <td> > [% IF CAN_user_cash_management_anonymous_refund && !(credit.debit.status == 'REFUNDED') && !(credit.debit.debit_type_code == 'PAYOUT') %] >- <button type="button" class="btn btn-default btn-xs pos_refund" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount | $Price %]" data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> >+ <button type="button" class="btn btn-default btn-xs pos_refund" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount %]" data-amountoutstanding="[% credit.debit.amountoutstanding %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> > [% ELSIF CAN_user_updatecharges_refund && !(credit.debit.status == 'REFUNDED') && credit.debit.borrowernumber && !(credit.debit.debit_type_code == 'PAYOUT') %] >- <button type="button" class="btn btn-default btn-xs" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount | $Price %]" data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> >+ <button type="button" class="btn btn-default btn-xs" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount %]" data-amountoutstanding="[% credit.debit.amountoutstanding %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> > [% END %] > </td> > </tr> >@@ -220,9 +220,9 @@ > <td></td> > <td> > [% IF CAN_user_cash_management_anonymous_refund && !(credit.debit.status == 'REFUNDED') && !(credit.debit.debit_type_code == 'PAYOUT') %] >- <button type="button" class="btn btn-default btn-xs pos_refund" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount | $Price %]" data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> >+ <button type="button" class="btn btn-default btn-xs pos_refund" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount %]" data-amountoutstanding="[% credit.debit.amountoutstanding %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> > [% ELSIF CAN_user_updatecharges_refund && !(credit.debit.status == 'REFUNDED') && credit.debit.borrowernumber && !(credit.debit.debit_type_code == 'PAYOUT') %] >- <button type="button" class="btn btn-default btn-xs" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount | $Price %]" data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> >+ <button type="button" class="btn btn-default btn-xs" data-bs-toggle="modal" data-bs-target="#issueRefundModal" data-item="[%- PROCESS account_type_description account=credit.debit -%]" data-accountline="[% credit.debit.accountlines_id | html %]" data-amount="[% credit.debit.amount %]" data-amountoutstanding="[% credit.debit.amountoutstanding %]" data-member="[% credit.debit.borrowernumber | html %]"><i class="fa-solid fa-money-bill-1"></i> Issue refund</button> > [% END %] > </td> > </tr> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41688
:
191871
|
191872