Bugzilla – Attachment 191874 Details for
Bug 40744
Don't give noisy warning when PatronSelfRegistration is turned off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40744: Ignore --del-exp-selfreg if pref is not set
Bug-40744-Ignore---del-exp-selfreg-if-pref-is-not-.patch (text/plain), 1.15 KB, created by
Ayoub Glizi-Vicioso
on 2026-01-22 15:58:56 UTC
(
hide
)
Description:
Bug 40744: Ignore --del-exp-selfreg if pref is not set
Filename:
MIME Type:
Creator:
Ayoub Glizi-Vicioso
Created:
2026-01-22 15:58:56 UTC
Size:
1.15 KB
patch
obsolete
>From 9d2d9734bbb113ce71b853777d67ce018aab35e6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 22 Jan 2026 16:13:44 +0100 >Subject: [PATCH] Bug 40744: Ignore --del-exp-selfreg if pref is not set > >If PatronSelfRegistration we should ignore (i.e. do nothing) if >--del-exp-selfreg is passed to cleanup_database.pl > >It prevents the script to warn that the pref is not set. >--- > misc/cronjobs/cleanup_database.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index 771846adfc..2299e59cc5 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -524,7 +524,7 @@ if ($verbose) { > say $confirm ? sprintf( "Deleted %d patrons", $count ) : sprintf( "%d patrons would have been deleted", $count ); > } > >-if ($pExpSelfReg) { >+if ( $pExpSelfReg && C4::Context->preference('PatronSelfRegistration') ) { > try { > my $opac_registrations = Koha::Patrons->search->filter_by_expired_opac_registrations->filter_by_safe_to_delete; > my $count = $opac_registrations->count; >-- >2.52.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40744
:
191869
|
191874
|
191875
|
191876
|
191877
|
191886
|
191887
|
191888
|
191889
|
191933
|
191934
|
192003
|
192004