Bugzilla – Attachment 191918 Details for
Bug 41521
WebService::ILS::OverDrive not passing pl_valid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41521: Remove perl valid warnings
013035c.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2026-01-23 11:05:26 UTC
(
hide
)
Description:
Bug 41521: Remove perl valid warnings
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-01-23 11:05:26 UTC
Size:
1.96 KB
patch
obsolete
>From 013035c52d6fc6aa1ba40f345ed44db7f1000ae7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 23 Jan 2026 09:32:16 +0100 >Subject: [PATCH] Bug 41521: Remove perl valid warnings > >% perl -wc Koha/ExternalContent/OverDrive.pm >Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365. >Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573. >Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643. >--- > lib/WebService/ILS/OverDrive/Patron.pm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/lib/WebService/ILS/OverDrive/Patron.pm b/lib/WebService/ILS/OverDrive/Patron.pm >index f7927ce511f..92e393093c9 100644 >--- a/lib/WebService/ILS/OverDrive/Patron.pm >+++ b/lib/WebService/ILS/OverDrive/Patron.pm >@@ -362,7 +362,8 @@ sub remove_hold { > sub { > my ($data) = @_; > return 1 if $data->{errorCode} eq "PatronDoesntHaveTitleOnHold"; >- die ($data->{message} || $data->{errorCode})."\n"; >+ my $error = ($data->{message} || $data->{errorCode})."\n"; >+ die $error; > }, > $url > ); >@@ -570,7 +571,8 @@ sub return { > sub { > my ($data) = @_; > return 1 if $data->{errorCode} eq "PatronDoesntHaveTitleCheckedOut"; >- die ($data->{message} || $data->{errorCode})."\n"; >+ my $error = ($data->{message} || $data->{errorCode})."\n"; >+ die $error; > }, > $url > ); >@@ -640,7 +642,8 @@ sub native_place_hold { > } > } > >- die ($data->{message} || $data->{errorCode})."\n"; >+ my $error = ($data->{message} || $data->{errorCode})."\n"; >+ die $error; > }, > $url, > {fields => \@fields} >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41521
:
191897
|
191898
|
191899
|
191900
|
191901
|
191902
|
191903
|
191904
|
191905
|
191917
|
191918
|
191919
|
192669
|
192670
|
192671
|
192672
|
192673
|
192674
|
192675
|
192676