Bugzilla – Attachment 191936 Details for
Bug 41695
Suggestion->refuser returns the manager
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41695: Fix rejecter in suggestion.pm
Bug-41695-Fix-rejecter-in-suggestionpm.patch (text/plain), 1.03 KB, created by
Baptiste Wojtkowski (bwoj)
on 2026-01-23 13:47:15 UTC
(
hide
)
Description:
Bug 41695: Fix rejecter in suggestion.pm
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2026-01-23 13:47:15 UTC
Size:
1.03 KB
patch
obsolete
>From e565bf6ef75d1dbc7baf5b66f68c0cae8743c376 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Fri, 23 Jan 2026 13:37:47 +0000 >Subject: [PATCH] Bug 41695: Fix rejecter in suggestion.pm > >TEST PLAN: >1 - Apply tests patch >2 - Run 'prove t/db_dependent/Koha/Suggestions.t' -> it fails on >rejecter >3 - Apply this patch >4 - Run 'prove t/db_dependent/Koha/Suggestions.t' -> it works > >Note: this patch also provide tests for remaining accessors in the >subtest >--- > Koha/Suggestion.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm >index e1e654c8d24..7efd4c02f46 100644 >--- a/Koha/Suggestion.pm >+++ b/Koha/Suggestion.pm >@@ -195,7 +195,7 @@ Returns the rejecter of the suggestion (Koha::Patron for rejectebby field) > > sub rejecter { > my ($self) = @_; >- my $rejecter_rs = $self->_result->managedby; >+ my $rejecter_rs = $self->_result->rejectedby; > return unless $rejecter_rs; > return Koha::Patron->_new_from_dbic($rejecter_rs); > } >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41695
:
191929
|
191930
| 191936