Bugzilla – Attachment 191952 Details for
Bug 41682
Syspref discrepancies between new and upgraded installs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41682: Fix 'integer' vs. 'Integer' inconsistency
7cadb26.patch (text/plain), 9.92 KB, created by
Tomás Cohen Arazi (tcohen)
on 2026-01-23 14:56:38 UTC
(
hide
)
Description:
Bug 41682: Fix 'integer' vs. 'Integer' inconsistency
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2026-01-23 14:56:38 UTC
Size:
9.92 KB
patch
obsolete
>From 7cadb265e1077e56a7152d9ac703bcee955c8780 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io> >Date: Fri, 23 Jan 2026 11:47:11 -0300 >Subject: [PATCH] Bug 41682: Fix 'integer' vs. 'Integer' inconsistency >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >There are 72 occurences for the 'Integer' type, and 8 for 'integer'. >Tests fail because of `StoreLastBorrower` already, so fixing them all for good. > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/atomicupdate/bug_41682.pl | 9 +++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 16 ++++++++-------- > 2 files changed, 17 insertions(+), 8 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_41682.pl b/installer/data/mysql/atomicupdate/bug_41682.pl >index 388f850134..0f2355c107 100755 >--- a/installer/data/mysql/atomicupdate/bug_41682.pl >+++ b/installer/data/mysql/atomicupdate/bug_41682.pl >@@ -26,6 +26,15 @@ return { > } > ); > >+ # At least StoreLastBorrower has type=integer >+ $dbh->do( >+ q{ >+ UPDATE systempreferences >+ SET type='Integer' >+ WHERE BINARY type='integer' >+ } >+ ); >+ > my $new_explanations = { > AcquisitionsDefaultEmailAddress => q{Default email address that acquisition notices are sent from}, > AdvancedSearchLanguages => >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index fa81de0d15..47dac4ecb4 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -77,7 +77,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AuthFailureLog','0',NULL,'If enabled, log authentication failures','YesNo'), > ('AuthoritiesLog','1',NULL,'If ON, log edit/create/delete actions on authorities.','YesNo'), > ('AuthorityControlledIndicators','# PERSO_NAME 100 600 696 700 796 800 896\nmarc21, 100, ind1:auth1\nmarc21, 600, ind1:auth1, ind2:thesaurus\nmarc21, 696, ind1:auth1\nmarc21, 700, ind1:auth1\nmarc21, 796, ind1:auth1\nmarc21, 800, ind1:auth1\nmarc21, 896, ind1:auth1\n# CORPO_NAME 110 610 697 710 797 810 897\nmarc21, 110, ind1:auth1\nmarc21, 610, ind1:auth1, ind2:thesaurus\nmarc21, 697, ind1:auth1\nmarc21, 710, ind1:auth1\nmarc21, 797, ind1:auth1\nmarc21, 810, ind1:auth1\nmarc21, 897, ind1:auth1\n# MEETI_NAME 111 611 698 711 798 811 898\nmarc21, 111, ind1:auth1\nmarc21, 611, ind1:auth1, ind2:thesaurus\nmarc21, 698, ind1:auth1\nmarc21, 711, ind1:auth1\nmarc21, 798, ind1:auth1\nmarc21, 811, ind1:auth1\nmarc21, 898, ind1:auth1\n# UNIF_TITLE 130 440 630 699 730 799 830 899\nmarc21, 130, ind1:auth2\nmarc21, 240, , ind2:auth2\nmarc21, 440, , ind2:auth2\nmarc21, 630, ind1:auth2, ind2:thesaurus\nmarc21, 699, ind1:auth2\nmarc21, 730, ind1:auth2\nmarc21, 799, ind1:auth2\nmarc21, 830, , ind2:auth2\nmarc21, 899, ind1:auth2\n# CHRON_TERM 648 \nmarc21, 648, , ind2:thesaurus\n# TOPIC_TERM 650 654 656 657 658 690\nmarc21, 650, , ind2:thesaurus\n# GEOGR_NAME 651 662 691\nmarc21, 651, , ind2:thesaurus\n# GENRE/FORM 655 \nmarc21, 655, , ind2:thesaurus\n\n# UNIMARC: Always copy the indicators from the authority\nunimarc, *, ind1:auth1, ind2:auth2',NULL,'Authority controlled indicators per biblio field','Free'), >-('AuthorityMergeLimit','50',NULL,'Maximum number of biblio records updated immediately when an authority record has been modified.','integer'), >+('AuthorityMergeLimit','50',NULL,'Maximum number of biblio records updated immediately when an authority record has been modified.','Integer'), > ('AuthorityMergeMode','loose','loose|strict','Authority merge mode','Choice'), > ('AuthoritySeparator','--','10','Used to separate a list of authorities in a display. Usually --','free'), > ('AuthorityXSLTDetailsDisplay','',NULL,'Enable XSL stylesheet control over authority details page display on intranet','Free'), >@@ -203,13 +203,13 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('DefaultClassificationSource','ddc',NULL,'Default classification scheme used by the collection. E.g., Dewey, LCC, etc.','ClassSources'), > ('DefaultCountryField008','',NULL,'Fill in the default country code for field 008 Range 15-17 of MARC21 - Place of publication, production, or execution. See <a href="http://www.loc.gov/marc/countries/countries_code.html">MARC Code List for Countries</a>','Free'), > ('DefaultHoldExpirationdate','0',NULL,'Automatically set expiration date for holds','YesNo'), >-('DefaultHoldExpirationdatePeriod','0',NULL,'How long into the future default expiration date is set to be.','integer'), >+('DefaultHoldExpirationdatePeriod','0',NULL,'How long into the future default expiration date is set to be.','Integer'), > ('DefaultHoldExpirationdateUnitOfTime','days','days|months|years','Which unit of time is used when setting the default expiration date. ','choice'), > ('DefaultHoldPickupLocation','loggedinlibrary','loggedinlibrary|homebranch|holdingbranch','Which branch should a hold pickup location default to. ','choice'), > ('DefaultLanguageField008','',NULL,'Fill in the default language for field 008 Range 35-37 of MARC21 records (e.g. eng, nor, ger, see <a href="http://www.loc.gov/marc/languages/language_code.html">MARC Code List for Languages</a>)','Free'), >-('DefaultLongOverdueChargeValue', '', NULL, 'Charge a lost item to the borrower\'s account when the LOST value of the item changes to n.', 'integer'), >-('DefaultLongOverdueDays', '', NULL, 'Set the LOST value of an item when the item has been overdue for more than n days.', 'integer'), >-('DefaultLongOverdueLostValue', '', NULL, 'Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.', 'integer'), >+('DefaultLongOverdueChargeValue', '', NULL, 'Charge a lost item to the borrower\'s account when the LOST value of the item changes to n.', 'Integer'), >+('DefaultLongOverdueDays', '', NULL, 'Set the LOST value of an item when the item has been overdue for more than n days.', 'Integer'), >+('DefaultLongOverdueLostValue', '', NULL, 'Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.', 'Integer'), > ('DefaultLongOverduePatronCategories', '', NULL, 'Set the patron categories that will be listed when longoverdue cronjob is executed', 'choice'), > ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost statuses by default in longoverdue.pl', 'Free'), > ('DefaultLongOverdueSkipPatronCategories', '', NULL, 'Set the patron categories that will not be listed when longoverdue cronjob is executed', 'choice'), >@@ -743,7 +743,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('SeparateHoldingsByGroup','0',NULL,'Separate current branch holdings and holdings from libraries in the same library groups','YesNo'), > ('SerialsDefaultEmailAddress', '', NULL, 'Default email address used as reply-to for notices sent by the serials module.', 'Free'), > ('SerialsDefaultReplyTo', '', NULL, 'Default email address that serials notices are sent from.', 'Free'), >-('SerialsSearchResultsLimit', '', NULL, 'Serials search results limit', 'integer'), >+('SerialsSearchResultsLimit', '', NULL, 'Serials search results limit', 'Integer'), > ('SessionRestrictionByIP','1',NULL,'Check for change in remote IP address for session security. Disable only when remote IP address changes frequently.','YesNo'), > ('SessionStorage','mysql','mysql|Pg|tmp','Use database or a temporary file for storing session data','Choice'), > ('ShelfBrowserUsesCcode','1',NULL,'Use the item collection code when finding items for the shelf browser.','YesNo'), >@@ -852,10 +852,10 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('UpdateNotForLoanStatusOnCheckin', '', NULL, 'This is a list of item types and value pairs.\nExamples:\n_ALL_:\n -1: 0\n\nCR:\n 1: 0\n\nWhen an item is checked in, if its item type matches CR then when the value on the left (1) matches the items not for loan value it will be updated to the value on the right.\n\nThe special term _ALL_ is used on the left side of the colon (:) to affect all item types. This does not override all other rules\n\nEach item type needs to be defined on a separate line on the left side of the colon (:).\nEach pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space.', 'Free'), > ('UpdateNotForLoanStatusOnCheckout', '', NULL, 'This is a list of value pairs. When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right. \nE.g. \'-1: 0\' will cause an item that was set to \'Ordered\' to now be available for loan. Each pair of values should be on a separate line.', 'Free'), > ('UpdateTotalIssuesOnCirc','0',NULL,'Whether to update the totalissues field in the biblio on each circ.','YesNo'), >-('UploadPurgeTemporaryFilesDays','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','integer'), >+('UploadPurgeTemporaryFilesDays','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','Integer'), > ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'), > ('URLLinkText','',NULL,'Text to display as the link anchor in the OPAC','free'), >-('UsageStats', '2', NULL, 'Share anonymous usage data on the Hea Koha community website.', 'integer'), >+('UsageStats', '2', NULL, 'Share anonymous usage data on the Hea Koha community website.', 'Integer'), > ('UsageStatsCountry', '', NULL, 'The country where your library is located, to be shown on the Hea Koha community website', 'Choice'), > ('UsageStatsGeolocation', '', NULL, 'Geolocation of the main library.', 'Free'), > ('UsageStatsID', '', NULL, 'This preference is part of Koha but it should not be deleted or updated manually.', 'Free'), >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41682
:
191858
|
191859
|
191906
|
191931
|
191932
|
191949
|
191950
|
191951
| 191952 |
191953
|
192017
|
192027
|
192031