Bugzilla – Attachment 191964 Details for
Bug 40703
Replace data-toggle by data-bs-toggle
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js
Bug-40703-QA-follow-up-Revert-change-to-bootstrapb.patch (text/plain), 4.94 KB, created by
Laura Escamilla
on 2026-01-23 16:50:26 UTC
(
hide
)
Description:
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2026-01-23 16:50:26 UTC
Size:
4.94 KB
patch
obsolete
>From a7dd8c428aeca687367f591f58b14659223fcd15 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 Jan 2026 11:37:37 -0500 >Subject: [PATCH] Bug 40703: (QA follow-up) Revert change to > bootstrap.bundle.js > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >--- > .../lib/bootstrap/js/bootstrap.bundle.js | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js b/koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js >index 473f493917..3c802e1ae5 100644 >--- a/koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js >+++ b/koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js >@@ -429,10 +429,10 @@ > var CLASS_NAME_ACTIVE = 'active'; > var CLASS_NAME_BUTTON = 'btn'; > var CLASS_NAME_FOCUS = 'focus'; >- var SELECTOR_DATA_TOGGLE_CARROT = '[data-bs-toggle="button"]'; >- var SELECTOR_DATA_TOGGLES = '[data-bs-toggle="buttons"]'; >- var SELECTOR_DATA_TOGGLE = '[data-bs-toggle="button"]'; >- var SELECTOR_DATA_TOGGLES_BUTTONS = '[data-bs-toggle="buttons"] .btn'; >+ var SELECTOR_DATA_TOGGLE_CARROT = '[data-toggle^="button"]'; >+ var SELECTOR_DATA_TOGGLES = '[data-toggle="buttons"]'; >+ var SELECTOR_DATA_TOGGLE = '[data-toggle="button"]'; >+ var SELECTOR_DATA_TOGGLES_BUTTONS = '[data-toggle="buttons"] .btn'; > var SELECTOR_INPUT = 'input:not([type="hidden"])'; > var SELECTOR_ACTIVE = '.active'; > var SELECTOR_BUTTON = '.btn'; >@@ -568,7 +568,7 @@ > }); > $(window).on(EVENT_LOAD_DATA_API, function () { > // ensure correct active class is set to match the controls' actual values/states >- // find all checkboxes/readio buttons inside data-bs-toggle groups >+ // find all checkboxes/readio buttons inside data-toggle groups > var buttons = [].slice.call(document.querySelectorAll(SELECTOR_DATA_TOGGLES_BUTTONS)); > > for (var i = 0, len = buttons.length; i < len; i++) { >@@ -1228,7 +1228,7 @@ > var DIMENSION_WIDTH = 'width'; > var DIMENSION_HEIGHT = 'height'; > var SELECTOR_ACTIVES = '.show, .collapsing'; >- var SELECTOR_DATA_TOGGLE$1 = '[data-bs-toggle="collapse"]'; >+ var SELECTOR_DATA_TOGGLE$1 = '[data-toggle="collapse"]'; > /** > * ------------------------------------------------------------------------ > * Class Definition >@@ -1240,7 +1240,7 @@ > this._isTransitioning = false; > this._element = element; > this._config = this._getConfig(config); >- this._triggerArray = [].slice.call(document.querySelectorAll("[data-bs-toggle=\"collapse\"][href=\"#" + element.id + "\"]," + ("[data-bs-toggle=\"collapse\"][data-bs-target=\"#" + element.id + "\"]"))); >+ this._triggerArray = [].slice.call(document.querySelectorAll("[data-toggle=\"collapse\"][href=\"#" + element.id + "\"]," + ("[data-toggle=\"collapse\"][data-bs-target=\"#" + element.id + "\"]"))); > var toggleList = [].slice.call(document.querySelectorAll(SELECTOR_DATA_TOGGLE$1)); > > for (var i = 0, len = toggleList.length; i < len; i++) { >@@ -1443,9 +1443,9 @@ > } > } else { > parent = document.querySelector(this._config.parent); >+ } > >- >- var selector = "[data-bs-toggle=\"collapse\"][data-parent=\"" + this._config.parent + "\"]"; >+ var selector = "[data-toggle=\"collapse\"][data-parent=\"" + this._config.parent + "\"]"; > var children = [].slice.call(parent.querySelectorAll(selector)); > $(children).each(function (i, element) { > _this3._addAriaAndCollapsedClass(Collapse._getTargetFromElement(element), [element]); >@@ -4199,7 +4199,7 @@ > var CLASS_NAME_DROPLEFT = 'dropleft'; > var CLASS_NAME_MENURIGHT = 'dropdown-menu-right'; > var CLASS_NAME_POSITION_STATIC = 'position-static'; >- var SELECTOR_DATA_TOGGLE$2 = '[data-bs-toggle="dropdown"]'; >+ var SELECTOR_DATA_TOGGLE$2 = '[data-toggle="dropdown"]'; > var SELECTOR_FORM_CHILD = '.dropdown form'; > var SELECTOR_MENU = '.dropdown-menu'; > var SELECTOR_NAVBAR_NAV = '.navbar-nav'; >@@ -4720,7 +4720,7 @@ > var CLASS_NAME_STATIC = 'modal-static'; > var SELECTOR_DIALOG = '.modal-dialog'; > var SELECTOR_MODAL_BODY = '.modal-body'; >- var SELECTOR_DATA_TOGGLE$3 = '[data-bs-toggle="modal"]'; >+ var SELECTOR_DATA_TOGGLE$3 = '[data-toggle="modal"]'; > var SELECTOR_DATA_DISMISS = '[data-dismiss="modal"]'; > var SELECTOR_FIXED_CONTENT = '.fixed-top, .fixed-bottom, .is-fixed, .sticky-top'; > var SELECTOR_STICKY_CONTENT = '.sticky-top'; >@@ -6602,7 +6602,7 @@ > var SELECTOR_NAV_LIST_GROUP$1 = '.nav, .list-group'; > var SELECTOR_ACTIVE$2 = '.active'; > var SELECTOR_ACTIVE_UL = '> li > .active'; >- var SELECTOR_DATA_TOGGLE$4 = '[data-bs-toggle="tab"], [data-bs-toggle="pill"], [data-bs-toggle="list"]'; >+ var SELECTOR_DATA_TOGGLE$4 = '[data-toggle="tab"], [data-toggle="pill"], [data-toggle="list"]'; > var SELECTOR_DROPDOWN_TOGGLE$1 = '.dropdown-toggle'; > var SELECTOR_DROPDOWN_ACTIVE_CHILD = '> .dropdown-menu .active'; > /** >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40703
:
191737
|
191799
|
191800
|
191844
|
191845
|
191964
|
192145