Bugzilla – Attachment 192045 Details for
Bug 41182
SUSHI harvest should send a full date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41182: Unit tests
Bug-41182-Unit-tests.patch (text/plain), 3.45 KB, created by
Nick Clemens (kidclamp)
on 2026-01-26 16:15:56 UTC
(
hide
)
Description:
Bug 41182: Unit tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2026-01-26 16:15:56 UTC
Size:
3.45 KB
patch
obsolete
>From 6ce18951966976c1e5a48d27dd30202bd7f1b775 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 26 Jan 2026 16:11:34 +0000 >Subject: [PATCH] Bug 41182: Unit tests > >--- > .../Koha/ERM/EUsage/UsageDataProvider.t | 36 ++++++++++++++++--- > 1 file changed, 32 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t >index ac82a0cd521..f4cc8744b0b 100755 >--- a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t >+++ b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t >@@ -32,7 +32,7 @@ my $builder = t::lib::TestBuilder->new; > > subtest '_build_url_query' => sub { > >- plan tests => 3; >+ plan tests => 4; > > $schema->storage->txn_begin; > >@@ -47,10 +47,14 @@ subtest '_build_url_query' => sub { > class => 'Koha::ERM::EUsage::UsageDataProviders', > value => { > service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, >- customer_id => $customer_id, name => $name, service_platform => undef, report_release => 5 >+ customer_id => $customer_id, name => $name, service_platform => undef, report_release => 5, >+ dateformat => undef, > } > } > ); >+ $usage_data_provider->discard_changes; >+ >+ # When date format is not specified we will use a 7 digit date in the url > > $usage_data_provider->{report_type} = 'TR_J1'; > $usage_data_provider->{begin_date} = '2023-08-01'; >@@ -80,7 +84,8 @@ subtest '_build_url_query' => sub { > class => 'Koha::ERM::EUsage::UsageDataProviders', > value => { > service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, >- customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => 5 >+ customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => 5, >+ dateformat => 7, > } > } > ); >@@ -113,7 +118,8 @@ subtest '_build_url_query' => sub { > class => 'Koha::ERM::EUsage::UsageDataProviders', > value => { > service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, >- customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => '5.1' >+ customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => '5.1', >+ dateformat => 7, > } > } > ); >@@ -141,6 +147,28 @@ subtest '_build_url_query' => sub { > . $test_platform > ); > >+ $usage_data_provider_51->dateformat(10)->store(); >+ >+ is( >+ $usage_data_provider_51->_build_url_query, >+ $service_url >+ . '/r51/reports/' >+ . lc( $usage_data_provider->{report_type} ) >+ . '?customer_id=' >+ . $customer_id >+ . '&requestor_id=' >+ . $requestor_id >+ . '&api_key=' >+ . $api_key >+ . '&begin_date=' >+ . substr( $usage_data_provider->{begin_date}, 0, 10 ) >+ . '&end_date=' >+ . substr( $usage_data_provider->{end_date}, 0, 10 ) >+ . '&platform=' >+ . $test_platform, >+ "When date format is set to 10 we send a 10 digit date" >+ ); >+ > $schema->storage->txn_rollback; > > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41182
:
189044
|
190713
|
192041
|
192042
|
192043
|
192044
|
192045
|
192046
|
192047
|
192048
|
192049
|
192050