Bugzilla – Attachment 192104 Details for
Bug 41715
Argument "YYYY-MM-DD" isn't numeric in numeric lt (<)... warnings in issues_stats.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41715: Argument "YYYY-MM-DD" isn't numeric in numeric lt (<)... warnings in issues_stats.pl
cbf3a78.patch (text/plain), 1.53 KB, created by
David Nind
on 2026-01-27 19:26:34 UTC
(
hide
)
Description:
Bug 41715: Argument "YYYY-MM-DD" isn't numeric in numeric lt (<)... warnings in issues_stats.pl
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-01-27 19:26:34 UTC
Size:
1.53 KB
patch
obsolete
>From cbf3a788acb1798b8bd702b9c48f85bc205503b8 Mon Sep 17 00:00:00 2001 >From: Roman Dolny <roman.dolny@jezuici.pl> >Date: Mon, 26 Jan 2026 22:12:10 +0000 >Subject: [PATCH] Bug 41715: Argument "YYYY-MM-DD" isn't numeric in numeric lt > (<)... warnings in issues_stats.pl > >The warnings: >[WARN] Argument "YYYY-MM-DD" isn't numeric in numeric lt (<) > at /kohadevbox/koha/reports/issues_stats.pl line 224. >appears in the plack-intranet-error.log. >It happens because a numerical comparison was used to compare the dates >instead of a string comparison. > >To test: >======== >1. Observe plack-intranet-error.log. >2. In staff interface go to Reports > Statistics wizards > Circulation. >3. Select date "From" and date "To" then submit. >4. Two warnings appear in plack-intranet-error.log. >5. Apply the patch; restart_all. >6. Repeat 2-3. No warnings appear in log. > >Sponsored-by: Ignatianum University in Cracow >Signed-off-by: David Nind <david@davidnind.com> >--- > reports/issues_stats.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 9439eb8aed..c0b550f613 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -221,7 +221,7 @@ sub calculate { > my %cell; > ( @$filters[$i] ) or next; > if ( ( $i == 1 ) and ( @$filters[ $i - 1 ] ) ) { >- $cell{err} = 1 if ( @$filters[$i] < @$filters[ $i - 1 ] ); >+ $cell{err} = 1 if ( @$filters[$i] lt @$filters[ $i - 1 ] ); > } > > # format the dates filters, otherwise just fill as is >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41715
:
192074
| 192104