Bugzilla – Attachment 192141 Details for
Bug 40826
nbofuser not incremented when using a mana report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40826: nbofuser increment when importing report from mana
Bug-40826-nbofuser-increment-when-importing-report.patch (text/plain), 1.72 KB, created by
elias.lorgnier@biblibre.com
on 2026-01-29 10:05:31 UTC
(
hide
)
Description:
Bug 40826: nbofuser increment when importing report from mana
Filename:
MIME Type:
Creator:
elias.lorgnier@biblibre.com
Created:
2026-01-29 10:05:31 UTC
Size:
1.72 KB
patch
obsolete
>From bb37891eba920cde7f3c961deea1374a004867ec Mon Sep 17 00:00:00 2001 >From: Elias <elias.lorgnier@biblibre.com> >Date: Mon, 13 Oct 2025 10:03:34 +0000 >Subject: [PATCH] Bug 40826: nbofuser increment when importing report from mana > >Test plan: >- Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana) >- By default there is no report loaded in mana, so you will want to create sample reports to be able to test the patch. You can simply uncomment the line in the `compose/base.yml`, under db -> volumes to add the sample reports. >- Add the bin/mana utility to your path >- run `mana up` to launch mana and create a docker network koha will connect to (see how to use the mana utility here : https://gitlab.com/koha-community/koha-mana/-/tree/main/compose?ref_type=heads) >- run `ktd --mana up` to connect koha to mana >2. Select a report already present on the mana instance to verify if the nbofuser will be incremented or create a new one >3. Import it in koha by searching it's name in the "New SQL from mana" menu >4. Once imported, check on the mana instance that the nbofuser has been incremented. (on the import SQL from mana menu, or on mana UI available on localhost:5000) >--- > svc/mana/use | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/svc/mana/use b/svc/mana/use >index 446c62e3d5e..37cb3674284 100755 >--- a/svc/mana/use >+++ b/svc/mana/use >@@ -49,6 +49,12 @@ my $resource; > > if ( $input->param('saveinbase') ) { > $resource = { id => $package->new_from_mana( $result->{data} )->id }; >+ Koha::SharedContent::increment_entity_value( >+ scalar $input->param('resource'), >+ scalar $input->param('id'), >+ 'nbofusers', >+ 1 >+ ); > } else { > $resource = $result->{data}; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40826
:
187831
|
187832
|
192141
|
192142