Bugzilla – Attachment 192193 Details for
Bug 41735
Remove double comma in source code for OPAC self-registration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41735: Tidy OPAC self-registration page
bdab97e.patch (text/plain), 1.44 KB, created by
David Nind
on 2026-01-29 18:56:56 UTC
(
hide
)
Description:
Bug 41735: Tidy OPAC self-registration page
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-01-29 18:56:56 UTC
Size:
1.44 KB
patch
obsolete
>From bdab97e7c3c64baad1cf84c45b5c782d0c45e6c7 Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Thu, 29 Jan 2026 18:07:51 +0000 >Subject: [PATCH] Bug 41735: Tidy OPAC self-registration page > >opac/opac-memberentry.pl has a double comma in the source code. > >Test plan: >1. Tidy the file: perl misc/devel/tidy.pl opac/opac-memberentry.pl >2. Generate a diff: git diff >3. Note the double comma. >4. Reset everything: git checkout opac/opac-memberentry.pl >5. Apply the patch. >6. Repeat steps 1 and 2 - no tidy changes made. >7. Run the qa script - there should be no warnings or errors: qa > >Signed-off-by: David Nind <david@davidnind.com> >--- > opac/opac-memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index ce530d4bb1..1daa2daf2c 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -277,7 +277,7 @@ if ( $op eq 'cud-create' ) { > my $letter = GetPreparedLetter( > module => 'members', > letter_code => 'WELCOME', >- branchcode => $patron->branchcode,, >+ branchcode => $patron->branchcode, > lang => $patron->lang || 'default', > tables => { > 'branches' => $patron->branchcode, >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41735
:
192180
| 192193