Bugzilla – Attachment 192221 Details for
Bug 23260
Anonymize (remove) patron data from items_last_borrower
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays
aefdb54.patch (text/plain), 5.73 KB, created by
Martin Renvoize (ashimema)
on 2026-01-30 11:14:50 UTC
(
hide
)
Description:
Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-01-30 11:14:50 UTC
Size:
5.73 KB
patch
obsolete
>From aefdb549813edf27736a162b8fbc145a9aa6a1f9 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 28 Nov 2023 13:27:27 +0000 >Subject: [PATCH] Bug 23260: Database updates and new system preferences > AnonymizeLastBorrower / AnonymizeLastBorrowerDays > >This patch alters the items_last_borrowers table to allow for NULL borrowers > >It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Peter Moore <peter@mrcpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > .../data/mysql/atomicupdate/bug_23260.pl | 33 +++++++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/mandatory/sysprefs.sql | 2 ++ > .../en/modules/admin/preferences/patrons.pref | 8 +++++ > 4 files changed, 44 insertions(+), 1 deletion(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_23260.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_23260.pl b/installer/data/mysql/atomicupdate/bug_23260.pl >new file mode 100755 >index 00000000000..c0033269bcd >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_23260.pl >@@ -0,0 +1,33 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_success say_info); >+ >+return { >+ bug_number => "23260", >+ description => >+ "Make created_on from items_last_borrower not update to current timestamp ON UPDATE, and add AnonymizeLastBorrower and AnonymizeLastBorrowerDays preferences", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ # Do you stuffs here >+ $dbh->do("ALTER TABLE items_last_borrower MODIFY COLUMN `borrowernumber` int(11) NULL"); >+ say_success( $out, "items_last_borrower updated to allow NULL borrowernumbers" ); >+ >+ $dbh->do( >+ q{ >+ ALTER TABLE items_last_borrower >+ MODIFY created_on timestamp NOT NULL DEFAULT current_timestamp() >+ } >+ ); >+ say_success( $out, "Fixed items_last_borrower.created_on column to prevent automatic timestamp updates" ); >+ >+ $dbh->do( >+ q{ >+ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES >+ ('AnonymizeLastBorrower','0',NULL,'If enabled, anonymize item\'s last borrower','YesNo'), >+ ('AnonymizeLastBorrowerDays','0',NULL,'Item\'s last borrower older than this preference will be anonymized','Integer') >+ } >+ ); >+ say_success( $out, "Added new system preferences 'AnonymizeLastBorrower' and 'AnonymizeLastBorrowerDays'" ); >+ }, >+}; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 733015e6e22..0fa24cb24b9 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -4256,7 +4256,7 @@ DROP TABLE IF EXISTS `items_last_borrower`; > CREATE TABLE `items_last_borrower` ( > `id` int(11) NOT NULL AUTO_INCREMENT, > `itemnumber` int(11) NOT NULL, >- `borrowernumber` int(11) NOT NULL, >+ `borrowernumber` int(11) NULL, > `created_on` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(), > PRIMARY KEY (`id`), > KEY `borrowernumber` (`borrowernumber`), >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 2476391b835..ba4aab1a3be 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -62,6 +62,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AmazonCoverImages','0',NULL,'Display Cover Images in staff interface from Amazon Web Services','YesNo'), > ('AmazonLocale','US','US|CA|DE|FR|IN|JP|UK','Use to set the Locale of your Amazon.com Web Services','Choice'), > ('AnonSuggestions','0',NULL,'Set to enable Anonymous suggestions to AnonymousPatron borrowernumber','YesNo'), >+('AnonymizeLastBorrower','0',NULL,'If enabled, anonymise item\'s last borrower','YesNo'), >+('AnonymizeLastBorrowerDays','0',NULL,'Item\'s last borrower older than this preference will be anonymised','Integer'), > ('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for suggestion and checkout history privacy',''), > ('ApiKeyLog', '0', NULL, 'If enabled, log API key actions (create, revoke, activate, delete)', 'YesNo'), > ('ApplyFrameworkDefaults', 'new', 'new|duplicate|changed|imported', 'Configure when to apply framework default values - when cataloguing a new record, or when editing a record as new (duplicating), or when changing framework, or when importing a record', 'multiple'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index d94bc0dd4bc..13012be74c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -468,6 +468,14 @@ Patrons: > initiator: populateCookieConsentedJS > processor: prepareCookieConsentedJS > - '<br><strong>NOTE:</strong> The cookie consent modal can be customised using the <a href="/cgi-bin/koha/tools/additional-contents.pl?category=html_customizations" target="_blank">CookieConsentPopup</a> html customisation.' >+ - >+ - pref: AnonymizeLastBorrower >+ choices: >+ yes: Anonymize >+ no: "Don't anonymize" >+ - " item's last borrower after " >+ - pref: AnonymizeLastBorrowerDays >+ - days. > Security: > - > - Login passwords for staff and patrons must be at least >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23260
:
92863
|
92864
|
93052
|
94858
|
94859
|
95033
|
95457
|
95458
|
95459
|
95460
|
95651
|
95698
|
95699
|
95700
|
95701
|
95769
|
95770
|
95771
|
95772
|
96791
|
97841
|
97842
|
98044
|
98053
|
98054
|
98064
|
98282
|
98349
|
98352
|
112734
|
112735
|
112736
|
112737
|
112738
|
112739
|
112740
|
112741
|
112742
|
112743
|
117974
|
117975
|
117976
|
117977
|
117978
|
117979
|
117980
|
117981
|
117982
|
117983
|
120522
|
120523
|
120524
|
120525
|
120526
|
120527
|
120528
|
120529
|
120530
|
120531
|
122963
|
122964
|
122965
|
122966
|
122967
|
122968
|
122969
|
122970
|
122971
|
122972
|
145175
|
145176
|
145177
|
145178
|
145179
|
145180
|
145181
|
145182
|
145183
|
145184
|
157106
|
157107
|
157108
|
157109
|
157110
|
157111
|
157112
|
157113
|
157114
|
157115
|
157116
|
159291
|
159292
|
159293
|
159294
|
159298
|
159299
|
159300
|
159301
|
164129
|
164130
|
164131
|
164132
|
164133
|
182000
|
182001
|
182002
|
182003
|
182004
|
182005
|
182006
|
182007
|
182927
|
182930
|
186835
|
186836
|
186837
|
186838
|
186839
|
186840
|
186843
|
186902
|
186942
|
186943
|
186948
|
187768
|
187769
|
187770
|
187771
|
187772
|
187773
|
187774
|
187775
|
187776
|
187777
|
187778
|
192200
|
192201
|
192202
|
192203
|
192204
|
192205
|
192206
|
192207
|
192208
|
192209
|
192210
|
192211
|
192212
|
192213
|
192214
|
192215
|
192216
|
192217
|
192218
|
192219
|
192220
| 192221 |
192222
|
192223
|
192224
|
192225
|
192226
|
192227
|
192228
|
192229
|
192230
|
192231
|
192232
|
192233