Bugzilla – Attachment 192233 Details for
Bug 23260
Anonymize (remove) patron data from items_last_borrower
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23260: (QA follow-up) Validate AnonymousPatron preference value
af5ee4b.patch (text/plain), 1.84 KB, created by
Martin Renvoize (ashimema)
on 2026-01-30 11:15:17 UTC
(
hide
)
Description:
Bug 23260: (QA follow-up) Validate AnonymousPatron preference value
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-01-30 11:15:17 UTC
Size:
1.84 KB
patch
obsolete
>From af5ee4b4b8f5cfd194ec2dbe3f31fb73578dc6ea Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 30 Jan 2026 11:01:37 +0000 >Subject: [PATCH] Bug 23260: (QA follow-up) Validate AnonymousPatron preference > value > >Add validation to ensure AnonymousPatron preference contains a valid >borrowernumber before attempting to use it in the anonymization process. >This prevents foreign key constraint errors and orphaned records if the >preference contains an invalid value (non-existent borrowernumber, >string instead of number, etc.). > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Patrons.pm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index 65131c0463d..8b802bdb53a 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -204,14 +204,17 @@ sub anonymize_last_borrowers { > my ( $self, $params ) = @_; > > return unless C4::Context->preference("AnonymizeLastBorrower"); >- return unless C4::Context->preference("AnonymousPatron"); >+ >+ my $anonymous_patron = C4::Context->preference('AnonymousPatron'); >+ return unless $anonymous_patron; >+ my $anon_patron_obj = Koha::Patrons->find($anonymous_patron); >+ return unless $anon_patron_obj; # Invalid AnonymousPatron value >+ > my $days = C4::Context->preference("AnonymizeLastBorrowerDays") || 0; > my ( $year, $month, $day ) = Today(); > my ( $newyear, $newmonth, $newday ) = Add_Delta_Days( $year, $month, $day, (-1) * $days ); > my $older_than_date = dt_from_string( sprintf "%4d-%02d-%02d", $newyear, $newmonth, $newday ); > >- my $anonymous_patron = C4::Context->preference('AnonymousPatron'); >- > my $dtf = Koha::Database->new->schema->storage->datetime_parser; > > # Perform bulk update directly on items_last_borrower table to avoid N+1 queries >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23260
:
92863
|
92864
|
93052
|
94858
|
94859
|
95033
|
95457
|
95458
|
95459
|
95460
|
95651
|
95698
|
95699
|
95700
|
95701
|
95769
|
95770
|
95771
|
95772
|
96791
|
97841
|
97842
|
98044
|
98053
|
98054
|
98064
|
98282
|
98349
|
98352
|
112734
|
112735
|
112736
|
112737
|
112738
|
112739
|
112740
|
112741
|
112742
|
112743
|
117974
|
117975
|
117976
|
117977
|
117978
|
117979
|
117980
|
117981
|
117982
|
117983
|
120522
|
120523
|
120524
|
120525
|
120526
|
120527
|
120528
|
120529
|
120530
|
120531
|
122963
|
122964
|
122965
|
122966
|
122967
|
122968
|
122969
|
122970
|
122971
|
122972
|
145175
|
145176
|
145177
|
145178
|
145179
|
145180
|
145181
|
145182
|
145183
|
145184
|
157106
|
157107
|
157108
|
157109
|
157110
|
157111
|
157112
|
157113
|
157114
|
157115
|
157116
|
159291
|
159292
|
159293
|
159294
|
159298
|
159299
|
159300
|
159301
|
164129
|
164130
|
164131
|
164132
|
164133
|
182000
|
182001
|
182002
|
182003
|
182004
|
182005
|
182006
|
182007
|
182927
|
182930
|
186835
|
186836
|
186837
|
186838
|
186839
|
186840
|
186843
|
186902
|
186942
|
186943
|
186948
|
187768
|
187769
|
187770
|
187771
|
187772
|
187773
|
187774
|
187775
|
187776
|
187777
|
187778
|
192200
|
192201
|
192202
|
192203
|
192204
|
192205
|
192206
|
192207
|
192208
|
192209
|
192210
|
192211
|
192212
|
192213
|
192214
|
192215
|
192216
|
192217
|
192218
|
192219
|
192220
|
192221
|
192222
|
192223
|
192224
|
192225
|
192226
|
192227
|
192228
|
192229
|
192230
|
192231
|
192232
| 192233