Bugzilla – Attachment 192273 Details for
Bug 41449
Reserves.t may fail when on shelf holds are restricted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41449: Reserves.t - fix description and assumption for onshelfholds
42e10ea.patch (text/plain), 1.30 KB, created by
Kyle M Hall (khall)
on 2026-01-30 19:09:30 UTC
(
hide
)
Description:
Bug 41449: Reserves.t - fix description and assumption for onshelfholds
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2026-01-30 19:09:30 UTC
Size:
1.30 KB
patch
obsolete
>From 42e10ea30d3fbabb4f5b54547693c208019d1af9 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 15 Dec 2025 12:29:52 +0100 >Subject: [PATCH] Bug 41449: Reserves.t - fix description and assumption for > onshelfholds > >Test plan: >prove t/db_dependent/Reserves.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Reserves.t | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 33a99d714e5..c10d08d4d9d 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -1483,9 +1483,15 @@ subtest 'IsAvailableForItemLevelRequest() tests' => sub { > value => { itemtype => $item_type } > } > ); >+ Koha::CirculationRules->set_rules( >+ { >+ categorycode => '*', itemtype => '*', branchcode => '*', >+ rules => { onshelfholds => 1 } >+ } >+ ); > ok( > C4::Reserves::IsAvailableForItemLevelRequest( $item, $patron ), >- "Item not available for item-level hold because no effective item type" >+ "Item available for item-level hold because defined effective item type" > ); > > Koha::CirculationRules->set_rules( >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41449
:
190496
| 192273