Bugzilla – Attachment 192370 Details for
Bug 34879
./catalogue/getitem-ajax.pl appears to be unused
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34879: Remove unused file from Koha
ab3be4f.patch (text/plain), 4.32 KB, created by
Jonathan Druart
on 2026-02-03 08:30:20 UTC
(
hide
)
Description:
Bug 34879: Remove unused file from Koha
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-02-03 08:30:20 UTC
Size:
4.32 KB
patch
obsolete
>From ab3be4fb9568cc8c95dad02da775db97e81518a2 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 3 Feb 2026 06:09:29 +0000 >Subject: [PATCH] Bug 34879: Remove unused file from Koha > >This change removes the "catalogue/getitem-ajax.pl" >which appears to be an unused file in Koha. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > catalogue/getitem-ajax.pl | 89 --------------------------------------- > 1 file changed, 89 deletions(-) > delete mode 100755 catalogue/getitem-ajax.pl > >diff --git a/catalogue/getitem-ajax.pl b/catalogue/getitem-ajax.pl >deleted file mode 100755 >index c26d0709895..00000000000 >--- a/catalogue/getitem-ajax.pl >+++ /dev/null >@@ -1,89 +0,0 @@ >-#!/usr/bin/perl >- >-# Copyright BibLibre 2012 >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <https://www.gnu.org/licenses>. >- >-use Modern::Perl; >-use CGI qw ( -utf8 ); >-use JSON qw( to_json ); >- >-use C4::Auth qw( check_api_auth ); >-use C4::Biblio qw( GetMarcStructure ); >-use C4::Output qw( output_with_http_headers ); >-use Koha::Libraries; >- >-use Koha::AuthorisedValues; >-use Koha::Items; >-use Koha::ItemTypes; >- >-my $cgi = CGI->new; >- >-my ( $status, $cookie, $sessionID ) = C4::Auth::check_api_auth( $cgi, { acquisition => 'order_receive' } ); >-unless ( $status eq "ok" ) { >- print $cgi->header( -type => 'application/json', -status => '403 Forbidden' ); >- print to_json( { auth_status => $status } ); >- exit 0; >-} >- >-my $item = {}; >-my $itemnumber = $cgi->param('itemnumber'); >- >-my $item_unblessed = {}; >-if ($itemnumber) { >- my $acq_fw = GetMarcStructure( 1, 'ACQ' ); >- my $fw = ($acq_fw) ? 'ACQ' : ''; >- $item = Koha::Items->find($itemnumber); >- $item_unblessed = $item->unblessed; # FIXME Not needed, call home_branch and holding_branch in the templates instead >- >- if ( $item->homebranch ) { # This test should not be needed, homebranch and holdingbranch are mandatory >- $item_unblessed->{homebranchname} = $item->home_branch->branchname; >- } >- >- if ( $item->holdingbranch ) { >- $item_unblessed->{holdingbranchname} = $item->holding_branch->branchname; >- } >- >- my $descriptions; >- $descriptions = Koha::AuthorisedValues->get_description_by_koha_field( >- { frameworkcode => $fw, kohafield => 'items.notforloan', authorised_value => $item->notforloan } ); >- $item_unblessed->{notforloan} = $descriptions->{lib} // ''; >- >- $descriptions = Koha::AuthorisedValues->get_description_by_koha_field( >- { frameworkcode => $fw, kohafield => 'items.restricted', authorised_value => $item->restricted } ); >- $item_unblessed->{restricted} = $descriptions->{lib} // ''; >- >- $descriptions = Koha::AuthorisedValues->get_description_by_koha_field( >- { frameworkcode => $fw, kohafield => 'items.location', authorised_value => $item->location } ); >- $item_unblessed->{location} = $descriptions->{lib} // ''; >- >- $descriptions = Koha::AuthorisedValues->get_description_by_koha_field( >- { frameworkcode => $fw, kohafield => 'items.ccode', authorised_value => $item->ccode } ); >- $item_unblessed->{collection} = $descriptions->{lib} // ''; >- >- $descriptions = Koha::AuthorisedValues->get_description_by_koha_field( >- { frameworkcode => $fw, kohafield => 'items.materials', authorised_value => $item->materials } ); >- $item_unblessed->{materials} = $descriptions->{lib} // ''; >- >- my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype ); >- >- # We should not do that here, but call ->itemtype->description when needed instea >- $item_unblessed->{itemtype} = $itemtype->description; # FIXME Should not it be translated_description? >-} >- >-my $json_text = to_json( $item_unblessed, { utf8 => 1 } ); >- >-output_with_http_headers $cgi, undef, $json_text, 'json'; >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34879
:
192355
| 192370