Bugzilla – Attachment 192381 Details for
Bug 38096
Field 857 is not considered for display on XSLT files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38096: (QA follow-up): Fix passing string param to template
Bug-38096-QA-follow-up-Fix-passing-string-param-to.patch (text/plain), 3.82 KB, created by
Pedro Amorim
on 2026-02-03 12:55:28 UTC
(
hide
)
Description:
Bug 38096: (QA follow-up): Fix passing string param to template
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2026-02-03 12:55:28 UTC
Size:
3.82 KB
patch
obsolete
>From 023c80a522ce47802483469f2f24d0f52af3ab0c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 3 Feb 2026 11:44:58 -0100 >Subject: [PATCH] Bug 38096: (QA follow-up): Fix passing string param to > template > >Upon following original test plan after rebase, noticed that >OPACDisplay856uAsImage wasn't working for 'Details' or 'Results'. >The culprit was how each screen is invoking the template, passing the >string param in a wrong XSL way. >--- > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 4 ++-- > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index ff227b3bd34..2396c3681c5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -1074,7 +1074,7 @@ > <xsl:with-param name="Show856uAsImage" select="$Show856uAsImage"></xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >- <xsl:with-param name="screen" select="detail"></xsl:with-param> >+ <xsl:with-param name="screen" select="'detail'"></xsl:with-param> > </xsl:call-template> > </ul> > </div> >@@ -1091,7 +1091,7 @@ > <xsl:with-param name="MARCOnlineResourceField">857</xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >- <xsl:with-param name="screen" select="detail"></xsl:with-param> >+ <xsl:with-param name="screen" select="'detail'"></xsl:with-param> > </xsl:call-template> > </ul> > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index cba5105e297..26071e7a485 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -1197,7 +1197,7 @@ > <xsl:with-param name="Show856uAsImage" select="$Show856uAsImage"></xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >- <xsl:with-param name="screen" select="results"></xsl:with-param> >+ <xsl:with-param name="screen" select="'results'"></xsl:with-param> > </xsl:call-template> > </ul> > </div> >@@ -1214,7 +1214,7 @@ > <xsl:with-param name="MARCOnlineResourceField">857</xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >- <xsl:with-param name="screen" select="results"></xsl:with-param> >+ <xsl:with-param name="screen" select="'results'"></xsl:with-param> > </xsl:call-template> > </ul> > </div> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38096
:
172466
|
172467
|
172468
|
172469
|
172470
|
172471
|
172532
|
172533
|
172534
|
172535
|
172536
|
192376
|
192377
|
192378
|
192379
|
192380
|
192381
|
192589
|
192590
|
192591
|
192592
|
192593
|
192594
|
192813
|
192814
|
192815
|
192816
|
192817
|
192818
|
192819
|
192906
|
192907
|
192908
|
192909
|
192910
|
192911
|
192919
|
192920
|
192921
|
192922
|
192966
|
193000