Bugzilla – Attachment 192432 Details for
Bug 7376
Transfer limits should be checked at check-in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7376: Unit test
Bug-7376-Unit-test.patch (text/plain), 3.01 KB, created by
Baptiste Wojtkowski (bwoj)
on 2026-02-04 08:53:22 UTC
(
hide
)
Description:
Bug 7376: Unit test
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2026-02-04 08:53:22 UTC
Size:
3.01 KB
patch
obsolete
>From 7f64a5a77b8eb3127ed6941c913a6f4b43ee7ef8 Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Mon, 16 Dec 2024 10:59:22 +0100 >Subject: [PATCH] Bug 7376: Unit test > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> >Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > t/db_dependent/Circulation.t | 45 +++++++++++++++++++++++++++++++++++- > 1 file changed, 44 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 97894daae45..af12b1d8783 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -19,7 +19,7 @@ use Modern::Perl; > use utf8; > > use Test::NoWarnings; >-use Test::More tests => 85; >+use Test::More tests => 86; > use Test::Exception; > use Test::MockModule; > use Test::Deep qw( cmp_deeply ); >@@ -2897,6 +2897,49 @@ subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub { > ); > }; > >+subtest 'CanBookBeReturned + UseBranchTransfertLimits' => sub { >+ plan tests => 6; >+ >+ my $homebranch = $builder->build( { source => 'Branch' } ); >+ my $otherbranch = $builder->build( { source => 'Branch' } ); >+ my $patron = >+ $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } ); >+ >+ my $item = $builder->build_sample_item( >+ { >+ homebranch => $homebranch->{branchcode}, >+ holdingbranch => $homebranch->{branchcode}, >+ } >+ ); >+ >+ t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' ); >+ set_userenv($homebranch); >+ my $issue = AddIssue( $patron, $item->barcode ); >+ my ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $otherbranch ); >+ is( 1, $allowed, 'with AllowReturnToBranch = anywhere and no limits return to other is allowed' ); >+ is( undef, $message, 'without limits provides no message' ); >+ >+ t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' ); >+ t::lib::Mocks::mock_preference( 'BranchTransferLimitsType', 'itemtype' ); >+ >+ # set limit >+ my $limit = Koha::Item::Transfer::Limit->new( >+ { >+ toBranch => $otherbranch->{branchcode}, >+ fromBranch => $item->homebranch, >+ itemtype => $item->effective_itemtype, >+ } >+ )->store(); >+ >+ ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $otherbranch ); >+ is( 0, $allowed, 'With transfer limits cannot return to otherbranch' ); >+ is( $homebranch->{branchcode}, $message, 'With transfer limits asks return to homebranch' ); >+ >+ ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $homebranch ); >+ is( 1, $allowed, 'With transfer limits can return to homebranch' ); >+ is( undef, $message, 'With transfer limits and homebranch provides no message' ); >+}; >+ > subtest 'Statistic patrons "X"' => sub { > plan tests => 15; > >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7376
:
6954
|
21715
|
21805
|
22016
|
22017
|
22323
|
22357
|
22696
|
23168
|
76559
|
76866
|
76876
|
92740
|
92774
|
93190
|
93191
|
93192
|
93193
|
93194
|
93195
|
93196
|
107077
|
107078
|
107079
|
115369
|
115370
|
116493
|
116494
|
116927
|
116928
|
116937
|
116938
|
120897
|
120898
|
120899
|
120900
|
120901
|
120902
|
120903
|
144435
|
144436
|
144437
|
144438
|
144439
|
144440
|
144441
|
175690
|
175691
|
175692
|
175693
|
175694
|
175695
|
175696
|
175697
|
180069
|
180070
|
180071
|
180072
|
180073
|
180074
|
180075
|
180076
|
180590
|
180591
|
180592
|
180593
|
180594
|
180595
|
180596
|
180597
|
181055
|
181056
|
181057
|
181058
|
181059
|
181060
|
181061
|
181062
|
181064
|
181065
|
181066
|
181067
|
181068
|
181069
|
181070
|
181071
|
191722
|
191723
|
191724
|
191725
|
191726
|
191727
|
191728
|
191729
|
192431
|
192432
|
192433
|
192434
|
192435
|
192436
|
192437
|
192438
|
192451
|
192452
|
192453
|
192454
|
192455
|
192456
|
192457
|
192458
|
192459