Bugzilla – Attachment 192465 Details for
Bug 41624
Revert Bug 35211
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array"
Bug-41624-Revert-Bug-35211-QA-follow-up-fix-displa.patch (text/plain), 2.54 KB, created by
Lucas Gass (lukeg)
on 2026-02-04 16:55:31 UTC
(
hide
)
Description:
Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array"
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-02-04 16:55:31 UTC
Size:
2.54 KB
patch
obsolete
>From 386302b91e8b8f1e6543e0c8d647a12bc7a36c30 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 4 Feb 2026 16:41:43 +0000 >Subject: [PATCH] Bug 41624: Revert "Bug 35211: (QA follow-up) fix display of > other results tab and move template toolkit logic outside of script array" > >This reverts commit c4c2a4b235ccefee0c54892c1ca1057465987918. >--- > .../prog/en/modules/catalogue/detail.tt | 20 +++++++------------ > 1 file changed, 7 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 48c85790537..00dbbe60db1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -357,7 +357,7 @@ > [% END %] > > [% IF Koha.Preference('SeparateHoldings') %] >- [% IF other_holdings_count > 0 %] >+ [% IF other_holdings_count %] > [% WRAPPER tab_item tabname= "otherholdings" %] > <span>Other holdings ([% other_holdings_count || 0 | html %])</span> > [% END %] >@@ -1763,29 +1763,23 @@ > [% END %] > <script> > var browser; >- var group_tabs; > browser = KOHA.browser("[% searchid | html %]", parseInt(biblionumber, 10)); > browser.show(); >- let group_tabs_array = new Array; >- [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] >- [% FOREACH group IN lib_groups %] >- group_tabs = "group_holdings_[% group.id | html %]" >- group_tabs_array.push(group_tabs); >- [% END %] >- [% END %] > > [% IF bundlesEnabled %] > var bundle_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail','bundle_tables','json') | $raw %]; > var bundle_lost_value = [% Koha.Preference('BundleLostValue') | html %]; > [% END %] > >- let items_tab_ids_default = [ >+ let items_tab_ids = [ > 'holdings', > 'otherholdings' >+ [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] >+ [% FOREACH group IN lib_groups %] >+ , 'group_holdings_[% group.id | html %]' >+ [% END %] >+ [% END %] > ]; >- >- let items_tab_ids = items_tab_ids_default.concat(group_tabs_array); >- > items_tab_ids.forEach( function( tab_id, index ) { > > // Early return if the tab is not shown (ie. no table) >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41624
:
191470
|
191471
|
192464
|
192465
|
192466
|
192467
|
192468
|
192469
|
192470
|
192471
|
192472
|
192473
|
192724
|
192725
|
192785
|
192786