Bugzilla – Attachment 192491 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: (QA follow-up) Guard against divide by zero
f897d50.patch (text/plain), 974 bytes, created by
Martin Renvoize (ashimema)
on 2026-02-04 18:38:52 UTC
(
hide
)
Description:
Bug 28530: (QA follow-up) Guard against divide by zero
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-04 18:38:52 UTC
Size:
974 bytes
patch
obsolete
>From f897d5080e0f9f63dfefd7c3c1eb904810dfbdd2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 4 Feb 2026 17:44:35 +0000 >Subject: [PATCH] Bug 28530: (QA follow-up) Guard against divide by zero > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Library/FloatLimits.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Library/FloatLimits.pm b/Koha/Library/FloatLimits.pm >index 2c82fdf25d5..df7c5c5f29b 100644 >--- a/Koha/Library/FloatLimits.pm >+++ b/Koha/Library/FloatLimits.pm >@@ -187,7 +187,8 @@ sub lowest_ratio_library { > } > } > >- my $ratio = $item_count / $float_limit_val; >+ # Guard against division by zero (float_limit_val should never be 0 due to search filter, but be safe) >+ my $ratio = $float_limit_val > 0 ? $item_count / $float_limit_val : 999999; > > push @candidates, { > branchcode => $branch, >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350
|
178762
|
178763
|
178764
|
178765
|
178766
|
178767
|
178768
|
178769
|
178783
|
178784
|
178785
|
178934
|
178935
|
178936
|
178937
|
178938
|
178939
|
178940
|
178941
|
178942
|
178943
|
178944
|
178945
|
178946
|
179943
|
179944
|
179945
|
179946
|
179947
|
179948
|
179949
|
179950
|
179951
|
179952
|
179953
|
179954
|
179955
|
180028
|
182931
|
184754
|
184755
|
184917
|
184936
|
184951
|
184952
|
184953
|
184954
|
184955
|
184956
|
184957
|
184958
|
184959
|
184960
|
184961
|
184963
|
184965
|
184966
|
184967
|
185038
|
185836
|
185837
|
185838
|
185839
|
185840
|
185841
|
185842
|
185843
|
187525
|
187601
|
190501
|
190502
|
190503
|
190504
|
190505
|
190506
|
190507
|
190508
|
190509
|
190510
|
190511
|
190512
|
190513
|
190547
|
190594
|
190595
|
190596
|
190597
|
190598
|
190599
|
190600
|
190601
|
190602
|
190603
|
190604
|
190605
|
190606
|
190607
|
192476
|
192477
|
192478
|
192479
|
192480
|
192481
|
192482
|
192483
|
192484
|
192485
|
192486
|
192487
|
192488
|
192489
|
192490
| 192491 |
192492
|
192493
|
192494
|
192495
|
192918
|
192954