Bugzilla – Attachment 192492 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: (QA follow-up) Use DBIC in controller
f8832b0.patch (text/plain), 2.08 KB, created by
Martin Renvoize (ashimema)
on 2026-02-04 18:38:54 UTC
(
hide
)
Description:
Bug 28530: (QA follow-up) Use DBIC in controller
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-04 18:38:54 UTC
Size:
2.08 KB
patch
obsolete
>From f8832b0dc275df3ba1cc26e31086ac73bbe14cda Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 4 Feb 2026 17:45:19 +0000 >Subject: [PATCH] Bug 28530: (QA follow-up) Use DBIC in controller > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > admin/float_limits.pl | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > >diff --git a/admin/float_limits.pl b/admin/float_limits.pl >index e68129eb4a9..6d1f820a3e6 100755 >--- a/admin/float_limits.pl >+++ b/admin/float_limits.pl >@@ -48,21 +48,25 @@ if ( $op eq 'cud-set_float_limits' ) { > > $schema->txn_do( > sub { >- $schema->storage->dbh->do("DELETE FROM library_float_limits"); >+ # Clear all existing float limits using DBIC >+ Koha::Library::FloatLimits->delete; > foreach my $branch (@branches) { > foreach my $itemtype (@itemtypes) { > my $branchcode = $branch->id; > my $itype = $itemtype->id; > > my $limit = $input->param( "limit_" . $branchcode . "_" . $itype ); >- Koha::Library::FloatLimit->new( >- { >- branchcode => $branchcode, >- itemtype => $itype, >- float_limit => $limit, >- } >- )->store() >- if $limit ne q{}; # update or insert >+ >+ # Validate: must be empty or a non-negative integer >+ if ( $limit ne q{} && $limit =~ /^\d+$/ && $limit >= 0 ) { >+ Koha::Library::FloatLimit->new( >+ { >+ branchcode => $branchcode, >+ itemtype => $itype, >+ float_limit => $limit, >+ } >+ )->store(); # update or insert >+ } > } > } > $template->param( float_limits_updated => 1 ); >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350
|
178762
|
178763
|
178764
|
178765
|
178766
|
178767
|
178768
|
178769
|
178783
|
178784
|
178785
|
178934
|
178935
|
178936
|
178937
|
178938
|
178939
|
178940
|
178941
|
178942
|
178943
|
178944
|
178945
|
178946
|
179943
|
179944
|
179945
|
179946
|
179947
|
179948
|
179949
|
179950
|
179951
|
179952
|
179953
|
179954
|
179955
|
180028
|
182931
|
184754
|
184755
|
184917
|
184936
|
184951
|
184952
|
184953
|
184954
|
184955
|
184956
|
184957
|
184958
|
184959
|
184960
|
184961
|
184963
|
184965
|
184966
|
184967
|
185038
|
185836
|
185837
|
185838
|
185839
|
185840
|
185841
|
185842
|
185843
|
187525
|
187601
|
190501
|
190502
|
190503
|
190504
|
190505
|
190506
|
190507
|
190508
|
190509
|
190510
|
190511
|
190512
|
190513
|
190547
|
190594
|
190595
|
190596
|
190597
|
190598
|
190599
|
190600
|
190601
|
190602
|
190603
|
190604
|
190605
|
190606
|
190607
|
192476
|
192477
|
192478
|
192479
|
192480
|
192481
|
192482
|
192483
|
192484
|
192485
|
192486
|
192487
|
192488
|
192489
|
192490
|
192491
| 192492 |
192493
|
192494
|
192495
|
192918
|
192954