Bugzilla – Attachment 192504 Details for
Bug 39204
Problem with cancelling a hold via SIP without marking it as waiting returns an error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39204: Added ability to cancel item-level holds via SIP
09957de.patch (text/plain), 1.63 KB, created by
David Nind
on 2026-02-04 21:16:54 UTC
(
hide
)
Description:
Bug 39204: Added ability to cancel item-level holds via SIP
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-02-04 21:16:54 UTC
Size:
1.63 KB
patch
obsolete
>From 09957de30de064b9e9ef33b369c67a40a977a96d Mon Sep 17 00:00:00 2001 >From: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Date: Fri, 29 Aug 2025 12:46:10 +0000 >Subject: [PATCH] Bug 39204: Added ability to cancel item-level holds via SIP >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: > >1. /kohadevbox/koha/misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m hold --patron 23529000035676 --item 39999000001310 --hold-mode + >2. /kohadevbox/koha/misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m hold --patron 23529000035676 --item 39999000001310 --hold-mode - >3. See the error: > 1. AFError with transaction drop_hold: >4. Apply the patch & restart_all >5. Try step 2 again. See confirmation: > 1. AFHold Cancelled. >6. prove t/db_dependent/Koha/Hold.t >7. Sign off รข have an amazing day! > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/SIP/ILS/Transaction/Hold.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm >index f2aeaff8db..1a8b7a5347 100644 >--- a/C4/SIP/ILS/Transaction/Hold.pm >+++ b/C4/SIP/ILS/Transaction/Hold.pm >@@ -69,7 +69,8 @@ sub do_hold { > priority => $priority, > branchcode => $branch, > borrowernumber => $patron->borrowernumber, >- biblionumber => $item->biblionumber >+ biblionumber => $item->biblionumber, >+ itemnumber => $item->itemnumber > } > ); > >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39204
:
185913
|
185921
|
188009
| 192504 |
192505