Bugzilla – Attachment 192520 Details for
Bug 35612
Record branch context in accountlines.branchcode for OVERDUE, LOST, and PROCESSING fees
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35612: (QA follow-up) Use interface parameter and remove self-referential use
9882eef.patch (text/plain), 2.40 KB, created by
Martin Renvoize (ashimema)
on 2026-02-05 08:54:05 UTC
(
hide
)
Description:
Bug 35612: (QA follow-up) Use interface parameter and remove self-referential use
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-05 08:54:05 UTC
Size:
2.40 KB
patch
obsolete
>From 9882eefbd6932fe99676a1c45954de66d6eecfb5 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 5 Feb 2026 08:11:14 +0000 >Subject: [PATCH] Bug 35612: (QA follow-up) Use interface parameter and remove > self-referential use > >This patch fixes two issues: > >1. C4::Accounts::chargelostitem now properly uses the $interface > variable that was set from $opts->{interface} instead of calling > C4::Context->interface directly. This ensures the interface > parameter is honored, particularly important for cronjob context. > >2. Removes the self-referential 'use Koha::Checkout;' statement in > Koha/Checkout.pm which is logically incorrect (a module should > not use itself). > >Test plan: >1. Run prove t/db_dependent/Accounts.t >2. Run prove t/db_dependent/Koha/Checkout.t >3. Verify all tests pass >--- > C4/Accounts.pm | 4 ++-- > Koha/Checkout.pm | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index b9c19a4adc7..6d8208980be 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -140,7 +140,7 @@ sub chargelostitem { > description => $description, > note => $processingfeenote, > user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, >- interface => C4::Context->interface, >+ interface => $interface, > library_id => $library_id, > type => 'PROCESSING', > item_id => $itemnumber, >@@ -157,7 +157,7 @@ sub chargelostitem { > description => $description, > note => undef, > user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, >- interface => C4::Context->interface, >+ interface => $interface, > library_id => $library_id, > type => 'LOST', > item_id => $itemnumber, >diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm >index 967b199a55d..63d657a67e6 100644 >--- a/Koha/Checkout.pm >+++ b/Koha/Checkout.pm >@@ -24,7 +24,6 @@ use DateTime; > use Try::Tiny qw( catch try ); > > use C4::Circulation qw( AddRenewal CanBookBeRenewed LostItem MarkIssueReturned ); >-use Koha::Checkout; > use Koha::Booking; > use Koha::Checkouts::Renewals; > use Koha::Checkouts::ReturnClaims; >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35612
:
186567
|
186568
|
186569
|
186570
|
186571
|
187919
|
187920
|
187921
|
187922
|
189137
|
192345
|
192346
|
192347
|
192348
|
192349
|
192385
|
192386
|
192387
|
192388
|
192389
|
192390
|
192497
|
192498
|
192499
|
192500
|
192501
|
192502
|
192513
|
192514
|
192515
|
192516
|
192517
|
192518
|
192519
| 192520 |
192521
|
192522