Bugzilla – Attachment 192584 Details for
Bug 41688
Refund modal and amount as NaN, rejected comma separator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41688: Fix NaN display in POS refund modal
f06c2b0.patch (text/plain), 5.49 KB, created by
David Nind
on 2026-02-06 07:36:15 UTC
(
hide
)
Description:
Bug 41688: Fix NaN display in POS refund modal
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-02-06 07:36:15 UTC
Size:
5.49 KB
patch
obsolete
>From f06c2b07d4479632be5d56cfc7fecb4213f469f5 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Mon, 2 Feb 2026 16:55:22 +0100 >Subject: [PATCH] Bug 41688: Fix NaN display in POS refund modal > >Test plan: > >Prerequisites: CurrencyFormat as 'FR' activated, have already produced a payment (with a comma separator) > >1. Go to POS > register > transaction history >2. Click "Issue refund" on any paid transaction >3. Verify "Amount paid" shows correct amount (not NaN but get the value > with comma separator) >4. Enter refund amount (point separator is mandatory to valid input) >5. Verify no validation error occurs >6. Process refund successfully > >Sponsored-by: BibLibre >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/pos/register.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index f6187dfac5..98ab252d0d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -144,8 +144,8 @@ > data-bs-target="#issueRefundModal" > data-item="[%- PROCESS account_type_description account=credit.debit -%]" > data-accountline="[% credit.debit.accountlines_id | html %]" >- data-amount="[% credit.debit.amount | $Price %]" >- data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" >+ data-amount="[% credit.debit.amount | html %]" >+ data-amountoutstanding="[% credit.debit.amountoutstanding | html %]" > data-member="[% credit.debit.borrowernumber | html %]" > ><i class="fa-solid fa-money-bill-1"></i> Issue refund</button > > >@@ -157,8 +157,8 @@ > data-bs-target="#issueRefundModal" > data-item="[%- PROCESS account_type_description account=credit.debit -%]" > data-accountline="[% credit.debit.accountlines_id | html %]" >- data-amount="[% credit.debit.amount | $Price %]" >- data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" >+ data-amount="[% credit.debit.amount | html %]" >+ data-amountoutstanding="[% credit.debit.amountoutstanding | html %]" > data-member="[% credit.debit.borrowernumber | html %]" > ><i class="fa-solid fa-money-bill-1"></i> Issue refund</button > > >@@ -279,8 +279,8 @@ > data-bs-target="#issueRefundModal" > data-item="[%- PROCESS account_type_description account=credit.debit -%]" > data-accountline="[% credit.debit.accountlines_id | html %]" >- data-amount="[% credit.debit.amount | $Price %]" >- data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" >+ data-amount="[% credit.debit.amount | html %]" >+ data-amountoutstanding="[% credit.debit.amountoutstanding | html %]" > data-member="[% credit.debit.borrowernumber | html %]" > ><i class="fa-solid fa-money-bill-1"></i> Issue refund</button > > >@@ -292,8 +292,8 @@ > data-bs-target="#issueRefundModal" > data-item="[%- PROCESS account_type_description account=credit.debit -%]" > data-accountline="[% credit.debit.accountlines_id | html %]" >- data-amount="[% credit.debit.amount | $Price %]" >- data-amountoutstanding="[% credit.debit.amountoutstanding | $Price %]" >+ data-amount="[% credit.debit.amount | html %]" >+ data-amountoutstanding="[% credit.debit.amountoutstanding | html %]" > data-member="[% credit.debit.borrowernumber | html %]" > ><i class="fa-solid fa-money-bill-1"></i> Issue refund</button > > >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41688
:
191871
|
191872
|
192333
| 192584 |
192585