Bugzilla – Attachment 192633 Details for
Bug 38384
General fix for plugins breaking database transactions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38384: (follow-up) move require Koha::Plugins to use
a691179.patch (text/plain), 2.41 KB, created by
Tomás Cohen Arazi (tcohen)
on 2026-02-06 15:22:00 UTC
(
hide
)
Description:
Bug 38384: (follow-up) move require Koha::Plugins to use
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2026-02-06 15:22:00 UTC
Size:
2.41 KB
patch
obsolete
>From a69117971a982cbdbf11c6ce383271c799509460 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 28 Jan 2026 14:34:00 +0000 >Subject: [PATCH] Bug 38384: (follow-up) move require Koha::Plugins to use >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >remaning ocurrences in test files seem okay, this covers the others > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > Koha/BackgroundJob.pm | 1 - > admin/marc_subfields_structure.pl | 2 +- > installer/data/mysql/updatedatabase.pl | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm >index b0c084a6c5..14950d23ab 100644 >--- a/Koha/BackgroundJob.pm >+++ b/Koha/BackgroundJob.pm >@@ -469,7 +469,6 @@ sub plugin_types_to_classes { > my ($self) = @_; > > unless ( exists $self->{_plugin_mapping} ) { >- require Koha::Plugins; > my @plugins = Koha::Plugins->new()->GetPlugins( { method => 'background_tasks', } ); > > foreach my $plugin (@plugins) { >diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl >index 3a88a79c2c..8b3e8b0ba3 100755 >--- a/admin/marc_subfields_structure.pl >+++ b/admin/marc_subfields_structure.pl >@@ -28,6 +28,7 @@ use Koha::Authority::Types; > use Koha::AuthorisedValueCategories; > use Koha::Filter::MARC::ViewPolicy; > use Koha::BiblioFrameworks; >+use Koha::Plugins; > > use List::MoreUtils qw( uniq ); > >@@ -128,7 +129,6 @@ if ( $op eq 'add_form' ) { > > # Add valuebuilders from plugins > if ( C4::Context->config("enable_plugins") ) { >- require Koha::Plugins; > my $plugins = Koha::Plugins->new(); > > # Use the dedicated get_valuebuilders_installed method >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index fa0acc38c2..9d1e08384b 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -44,6 +44,7 @@ use Koha; > use Koha::DateUtils qw( dt_from_string output_pref ); > use Koha::Caches; > use Koha::Installer::Output qw ( say_failure ); >+use Koha::Plugins; > > use MARC::Record; > use MARC::File::XML ( BinaryEncoding => 'utf8' ); >@@ -23035,7 +23036,6 @@ if ( CheckVersion($DBversion) ) { > ); > } > >- require Koha::Plugins; > Koha::Plugins->new( { enable_plugins => 1 } )->InstallPlugins; > > SetVersion($DBversion); >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38384
:
174150
|
174264
|
174265
|
174280
|
174282
|
189636
|
189637
|
189638
|
189639
|
189640
|
190514
|
190515
|
190516
|
190517
|
191860
|
192119
|
192628
|
192629
|
192630
|
192631
|
192632
|
192633
|
192662
|
192663
|
192664
|
192665
|
192666
|
192667
|
193142
|
193143
|
193144
|
193171
|
193172
|
193173
|
193174
|
193175
|
193176
|
193177
|
193178
|
193179