Bugzilla – Attachment 192634 Details for
Bug 41788
Make running the holds queue on click optional
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41788: Add system preference UseHoldsQueueFilterOptions
Bug-41788-Add-system-preference-UseHoldsQueueFilte.patch (text/plain), 5.59 KB, created by
Lucas Gass (lukeg)
on 2026-02-06 15:29:27 UTC
(
hide
)
Description:
Bug 41788: Add system preference UseHoldsQueueFilterOptions
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-02-06 15:29:27 UTC
Size:
5.59 KB
patch
obsolete
>From b090dbe2b3dad870356a84e16d01007c5b785d47 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 6 Feb 2026 15:22:30 +0000 >Subject: [PATCH] Bug 41788: Add system preference UseHoldsQueueFilterOptions > >--- > .../data/mysql/atomicupdate/bug_41788.pl | 20 +++++++++++++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 5 +++-- > .../admin/preferences/circulation.pref | 6 ++++++ > 3 files changed, 29 insertions(+), 2 deletions(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_41788.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_41788.pl b/installer/data/mysql/atomicupdate/bug_41788.pl >new file mode 100755 >index 00000000000..ce92c1978c2 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_41788.pl >@@ -0,0 +1,20 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_success say_info); >+ >+return { >+ bug_number => "41788", >+ description => "Add UseHoldsQueueFilterOptions system preference", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ # Do you stuffs here >+ $dbh->do( >+ q{ >+ INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) >+ VALUES ('UseHoldsQueueFilterOptions','1','','If enabled, the holds queue will present the user with filter options before running','YesNo') >+ } >+ ); >+ say_success( $out, "UseHoldsQueueFilterOptions system preference added" ); >+ }, >+}; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 9d91ed1861e..cc3865e2535 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -488,7 +488,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OpacAllowPublicListCreation','1',NULL,'If set, allows opac users to create public lists','YesNo'), > ('OpacAllowSharingPrivateLists','0',NULL,'If set, allows opac users to share private lists with other patrons','YesNo'), > ('OPACAllowUserToChangeBranch','','Pending, In-Transit, Suspended','Allow users to change the library to pick up a hold for these statuses:','multiple'), >-('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'), >+/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'), > ('OPACAmazonCoverImages','0',NULL,'Display cover images on OPAC from Amazon Web Services','YesNo'), > ('OPACAuthorIdentifiersAndInformation', '', NULL, 'Display author information on the OPAC detail page','multiple_sortable'), > ('OpacAuthorities','1',NULL,'If ON, enables the search authorities link on OPAC','YesNo'), >@@ -578,7 +578,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OPACShowLibraries', '1', NULL, 'If enabled, a "Libraries" link appears in the OPAC pointing to a page with library information', 'YesNo'), > ('OPACShowMusicalInscripts','0',NULL,'Display musical inscripts on the OPAC record details page when available.','YesNo'), > ('OPACShowOpenURL', '0', NULL, 'Enable display of OpenURL links in OPAC search results and detail page', 'YesNo'), >-('OpacShowRecentComments','0',NULL,'If ON a link to recent comments will appear in the OPAC masthead','YesNo'), >+('OpacShowRecentComments','0',NULL,'If ON a link to recent c/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sqlomments will appear in the OPAC masthead','YesNo'), > ('OPACShowSavings', '', 'checkouthistory|summary|user', 'Show on the OPAC the total amount a patron has saved by using a library instead of purchasing, based on replacement prices', 'multiple'), > ('OPACShowUnusedAuthorities','1',NULL,'Show authorities that are not being used in the OPAC.','YesNo'), > ('OpacStarRatings','all','disable|all|details',NULL,'Choice'), >@@ -880,6 +880,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('UseLocationAsAQInSIP', '0', NULL, 'Use permanent_location instead of homebranch for AQ in SIP response', 'YesNo'), > ('UseOCLCEncodingLevels','0',NULL,'If enabled, include OCLC encoding levels in leader value builder dropdown for position 17.','YesNo'), > ('UseRecalls','0',NULL,'Enable or disable recalls','YesNo'), >+('UseHoldsQueueFilterOptions','1',NULL,'If enabled, the holds queue will present the user with filter options before running','YesNo'), > ('UseTransportCostMatrix','0',NULL,'Use Transport Cost Matrix when filling holds','YesNo'), > ('UseWYSIWYGinSystemPreferences','0',NULL,'Show WYSIWYG editor when editing certain HTML system preferences.','YesNo'), > ('viewISBD','1',NULL,'Allow display of ISBD view of bibiographic records','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 9ebf5601eeb..b2b91ae89e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -798,6 +798,12 @@ Circulation: > actual: "the actual priority, which may be out of order" > virtual: "'virtual' priorities, where each group is numbered separately" > - . >+ - >+ - pref: UseHoldsQueueFilterOptions >+ choices: >+ 1: Enable >+ 0: Disable >+ - when running the holds queue. > - > - pref: RealTimeHoldsQueue > choices: >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41788
: 192634 |
192635