Bugzilla – Attachment 192652 Details for
Bug 41173
ERM breadcrumb link causes page reload
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41173: (follow-up) Don't pass params to base routes in breadcrumbs
d0d2554.patch (text/plain), 1.54 KB, created by
Tomás Cohen Arazi (tcohen)
on 2026-02-06 17:09:06 UTC
(
hide
)
Description:
Bug 41173: (follow-up) Don't pass params to base routes in breadcrumbs
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2026-02-06 17:09:06 UTC
Size:
1.54 KB
patch
obsolete
>From d0d2554186ef633693892b226ec2644a3dfbf64b Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io> >Date: Fri, 6 Feb 2026 12:30:55 -0300 >Subject: [PATCH] Bug 41173: (follow-up) Don't pass params to base routes in > breadcrumbs > >The ERMHome route is a base route that doesn't accept params, but >NavigationItem was passing all current route params (license_id, >agreement_id, etc.) to it, causing Vue Router errors. > >Fix by checking if the route is a base route (is_base flag) and >passing an empty params object in that case. > >Test plan: >1. Run Cypress tests: yarn cypress run >2. Verify AdditionalFields_spec.ts now passes all 12 tests >3. Navigate to ERM module and verify breadcrumbs work correctly >--- > .../intranet-tmpl/prog/js/vue/components/NavigationItem.vue | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >index 59597e4997..3488e35479 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >@@ -3,7 +3,7 @@ > <span> > <router-link > v-if="item.name && !item.disabled" >- :to="{ name: item.name, params }" >+ :to="{ name: item.name, params: item.is_base ? {} : params }" > > > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41173
:
188983
|
188984
|
189369
|
189431
|
189550
|
192244
| 192652