Bugzilla – Attachment 192676 Details for
Bug 41521
WebService::ILS::OverDrive not passing pl_valid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41521: Silent perlcritic warnings
Bug-41521-Silent-perlcritic-warnings.patch (text/plain), 2.74 KB, created by
Victor Grousset/tuxayo
on 2026-02-07 17:28:44 UTC
(
hide
)
Description:
Bug 41521: Silent perlcritic warnings
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2026-02-07 17:28:44 UTC
Size:
2.74 KB
patch
obsolete
>From 6e345dab20f31aecb6c77b1aab7caf11e752e479 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 23 Jan 2026 10:35:53 +0100 >Subject: [PATCH] Bug 41521: Silent perlcritic warnings > >Stricture disabled at line 67, column 5. See page 429 of PBP. (Severity: 5) > >We should deal with that later instead of ignoring the warnings > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > lib/WebService/ILS/JSON.pm | 2 +- > lib/WebService/ILS/OverDrive.pm | 2 +- > lib/WebService/ILS/RecordedBooks/Partner.pm | 2 +- > lib/WebService/ILS/XML.pm | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/lib/WebService/ILS/JSON.pm b/lib/WebService/ILS/JSON.pm >index d4495a55a1..1cadd5c2e9 100644 >--- a/lib/WebService/ILS/JSON.pm >+++ b/lib/WebService/ILS/JSON.pm >@@ -104,7 +104,7 @@ sub with_json_request { > my $method = shift || 'post'; > > my $req_builder = "HTTP::Request::Common::".uc( $method ); >- no strict 'refs'; >+ no strict 'refs'; ## no critic (ProhibitNoStrict) > my $request = $req_builder->( $url ); > $self->_json_request_content($request, $post_params); > my $response = $self->_request_with_auth($request); >diff --git a/lib/WebService/ILS/OverDrive.pm b/lib/WebService/ILS/OverDrive.pm >index 963484c896..5ee8aec9ce 100644 >--- a/lib/WebService/ILS/OverDrive.pm >+++ b/lib/WebService/ILS/OverDrive.pm >@@ -273,7 +273,7 @@ sub native_search { > } > > foreach my $f (qw(next prev first last)) { >- no strict 'refs'; >+ no strict 'refs'; ## no critic (ProhibitNoStrict) > my $method = "native_search_$f"; > *$method = sub { > my $self = shift; >diff --git a/lib/WebService/ILS/RecordedBooks/Partner.pm b/lib/WebService/ILS/RecordedBooks/Partner.pm >index 424398c5e5..d95d24e038 100644 >--- a/lib/WebService/ILS/RecordedBooks/Partner.pm >+++ b/lib/WebService/ILS/RecordedBooks/Partner.pm >@@ -63,7 +63,7 @@ Differences to general L<WebService::ILS> interface > =cut > > foreach my $sub (qw(place_hold remove_hold renew return)) { >- no strict "refs"; >+ no strict "refs"; ## no critic (ProhibitNoStrict) > *$sub = sub { > my $self = shift; > my $patron_id = shift or croak "No patron id"; >diff --git a/lib/WebService/ILS/XML.pm b/lib/WebService/ILS/XML.pm >index dd7c72359f..0eab4e32f8 100644 >--- a/lib/WebService/ILS/XML.pm >+++ b/lib/WebService/ILS/XML.pm >@@ -73,7 +73,7 @@ sub with_xml_request { > my $method = shift || 'post'; > > my $req_builder = "HTTP::Request::Common::".uc( $method ); >- no strict 'refs'; >+ no strict 'refs'; ## no critic (ProhibitNoStrict) > my $request = $req_builder->( $url ); > $request->header( 'Content-Type' => 'application/xml; charset=utf-8' ); > $request->content( $dom->toeString ); >-- >2.53.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41521
:
191897
|
191898
|
191899
|
191900
|
191901
|
191902
|
191903
|
191904
|
191905
|
191917
|
191918
|
191919
|
192669
|
192670
|
192671
|
192672
|
192673
|
192674
|
192675
| 192676