Bugzilla – Attachment 192715 Details for
Bug 41572
Tidy kohaTable block - members
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41572: Tidy kohaTable - members/holdshistory.tt
621db3f.patch (text/plain), 2.54 KB, created by
Jonathan Druart
on 2026-02-09 09:09:06 UTC
(
hide
)
Description:
Bug 41572: Tidy kohaTable - members/holdshistory.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-02-09 09:09:06 UTC
Size:
2.54 KB
patch
obsolete
>From 621db3fd358a7dc87a7f2815a857608324846bfe Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 14:08:19 +0100 >Subject: [PATCH] Bug 41572: Tidy kohaTable - members/holdshistory.tt > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/members/holdshistory.tt | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >index b4426991d99..d693ecbe6cd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >@@ -176,11 +176,13 @@ > }; > > const show_itemtype_column = [% Koha.Preference('AllowHoldItemTypeSelection') ? 1 : 0 | html %]; >+ >+ var table_settings = [% TablesSettings.GetTableSettings('members', 'holdshistory', 'holdshistory-table', 'json') | $raw %]; >+ >+ const patron_id = "[% patron.borrowernumber | html %]"; > </script> > <script> > $(document).ready(function() { >- var table_settings = [% TablesSettings.GetTableSettings('members', 'holdshistory', 'holdshistory-table', 'json') | $raw %]; >- > let item_type_column = table_settings.columns.find(c => c.columnname == 'itemtype'); > if ( !show_itemtype_column ) { > item_type_column.is_hidden = 1; >@@ -227,7 +229,7 @@ > > }; > >- let table_url = '/api/v1/patrons/[% patron.borrowernumber | uri %]/holds'; >+ let table_url = `/api/v1/patrons/${patron_id}/holds`; > let table_embeds = ['+strings', 'biblio', 'item', 'pickup_library']; > if (old){ > table_url += '?old=1'; >@@ -323,7 +325,8 @@ > return $date(row.cancellation_date) > } > }, >- { >+ ...(show_itemtype_column? >+ [{ > data: "item_type_id", > datatype: "coded_value:item_type", > dataFilter: "item_types", >@@ -340,7 +343,7 @@ > return ""; > [% END %] > } >- }, >+ ]:[]), > { > data: "status", > searchable: false, >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41572
:
191133
|
191134
|
191135
|
191136
|
191137
|
191138
|
191521
|
191522
|
191523
|
191524
|
191525
|
191526
|
191527
|
191528
|
192714
| 192715 |
192716
|
192717
|
192718
|
192719
|
192720
|
192721
|
192722