Bugzilla – Attachment 192786 Details for
Bug 41624
Revert Bug 35211
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41624: Simplify db rev
Bug-41624-Simplify-db-rev.patch (text/plain), 1.92 KB, created by
Paul Derscheid
on 2026-02-09 12:28:43 UTC
(
hide
)
Description:
Bug 41624: Simplify db rev
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-02-09 12:28:43 UTC
Size:
1.92 KB
patch
obsolete
>From 1938a7896bdda36e0af776e773893d7d07c22406 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 9 Feb 2026 11:35:00 +0100 >Subject: [PATCH] Bug 41624: Simplify db rev > >Also fix QA failures: >[FAIL] installer/data/mysql/atomicupdate/bug_41624.pl > FAIL file_permissions > File must have the exec flag > FAIL forbidden_patterns > forbidden pattern: trailing space char (line 13) > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../data/mysql/atomicupdate/bug_41624.pl | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_41624.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_41624.pl b/installer/data/mysql/atomicupdate/bug_41624.pl >old mode 100644 >new mode 100755 >index 750b0b064a0..3b9afec4b6b >--- a/installer/data/mysql/atomicupdate/bug_41624.pl >+++ b/installer/data/mysql/atomicupdate/bug_41624.pl >@@ -8,24 +8,11 @@ return { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; > >- # Check if the preference exists before removing >- my ($exists) = $dbh->selectrow_array( >+ $dbh->do( > q{ >- SELECT COUNT(*) >- FROM systempreferences >+ DELETE FROM systempreferences > WHERE variable = 'SeparateHoldingsByGroup' > } >- ); >- >- if ($exists) { >- $dbh->do( >- q{ >- DELETE FROM systempreferences >- WHERE variable = 'SeparateHoldingsByGroup' >- } >- ); >- } >- >- say_success( $out, "Removed system preference 'SeparateHoldingsByGroup'" ); >+ ) != '0E0' && say_success( $out, "Removed system preference 'SeparateHoldingsByGroup'" ); > }, > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41624
:
191470
|
191471
|
192464
|
192465
|
192466
|
192467
|
192468
|
192469
|
192470
|
192471
|
192472
|
192473
|
192724
|
192725
|
192785
| 192786