Bugzilla – Attachment 192807 Details for
Bug 37707
Lead/Trail times should work in combination
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37707: (QA follow-up) Fix incorrect bold date expectations in Cypress test
Bug-37707-QA-follow-up-Fix-incorrect-bold-date-exp.patch (text/plain), 2.51 KB, created by
Paul Derscheid
on 2026-02-09 14:50:46 UTC
(
hide
)
Description:
Bug 37707: (QA follow-up) Fix incorrect bold date expectations in Cypress test
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-02-09 14:50:46 UTC
Size:
2.51 KB
patch
obsolete
>From ed454828ff3e9fe94c93c79ad0857add80a078f6 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Mon, 9 Feb 2026 15:25:34 +0100 >Subject: [PATCH] Bug 37707: (QA follow-up) Fix incorrect bold date > expectations in Cypress test > >- The test for circulation rules date calculations did not account for > the start date being bold, only the period endpoint dates >- place_booking.js explicitly adds the selected start date to boldDates > (boldDates = [new Date(startDate)]), giving it the "title" class >- The verification loop checking for unexpected bold dates then failed > when it encountered the start date, which was bold but not expected >- Add clearZoneStart to expectedBoldDates to match actual behavior > >To test: >- yarn cypress run --spec t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts >- Verify that the "should handle circulation rules date calculations and visual feedback" test now passes > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../integration/Circulation/bookingsModalDatePicker_spec.ts | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts b/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts >index 384387dab54..fc7a0d1a938 100644 >--- a/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts >+++ b/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts >@@ -452,6 +452,7 @@ describe("Booking Modal Date Picker Tests", () => { > * ΓΆΓΆ Renewal 1 Period (Days 60-64) > * > * Expected Visual Styling: >+ * - Day 50: Bold (start date) > * - Day 59: Bold (issue period) > * - Day 64: Bold (renewal 1 period) > * - Day 69: Bold (renewal 2 period) >@@ -561,9 +562,12 @@ describe("Booking Modal Date Picker Tests", () => { > */ > > // Calculate expected bold dates based on circulation rules (like original test) >- // Bold dates occur at period endpoints: start + issuelength, start + issuelength + renewalperiod, etc. >+ // Bold dates occur at: the start date itself, plus period endpoints > const expectedBoldDates = []; > >+ // Start date is always bold (see place_booking.js boldDates = [new Date(startDate)]) >+ expectedBoldDates.push(clearZoneStart); >+ > // Issue period end (after issuelength days) > expectedBoldDates.push( > clearZoneStart.add(dateTestCirculationRules.issuelength, "day") >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37707
:
182718
|
190859
|
190860
|
190861
|
190862
|
191000
|
191001
|
191002
|
191003
|
191232
|
191233
|
191350
|
191351
|
191352
|
191353
|
191354
|
191355
|
191356
|
191357
|
191358
|
191359
|
191360
|
191361
|
191394
|
191395
|
191746
|
192006
|
192007
|
192008
|
192009
|
192010
|
192800
|
192801
|
192802
|
192803
|
192804
|
192805
|
192806
|
192807
|
192863
|
192864
|
192865
|
192866
|
192867
|
192868
|
192869
|
192870