Bugzilla – Attachment 192808 Details for
Bug 41747
xt/js_tidy is failing on ill js files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41747: Tidy js/ill-availability.js
Bug-41747-Tidy-jsill-availabilityjs.patch (text/plain), 2.24 KB, created by
Lucas Gass (lukeg)
on 2026-02-09 15:29:06 UTC
(
hide
)
Description:
Bug 41747: Tidy js/ill-availability.js
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-02-09 15:29:06 UTC
Size:
2.24 KB
patch
obsolete
>From 055330ea3faf921cf569966626562f032eb5c269 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 Feb 2026 10:32:39 +0100 >Subject: [PATCH] Bug 41747: Tidy js/ill-availability.js > >xt/js_tidy.t does not check all files every run (it's using the incremental runs). >Something happened (node version changed?) and this is triggered because bug 41512 modified those files > >Test plan: >0. Do not apply this patch >1. KOHA_CI_INCREMENTAL_RUNS=1 prove xt/js_tidy.t >=> fail >2. Apply this patch >3. Run prove again >=> pass > >4. Run prove without the env var set >=> pass (i.e. there are no other JS files not tidy) > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/ill-availability.js | 2 +- > koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-availability.js b/koha-tmpl/intranet-tmpl/prog/js/ill-availability.js >index 8807dd95b6f..64dd000b7e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-availability.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-availability.js >@@ -119,7 +119,7 @@ $(document).ready(function () { > pageSize = results.length; > // These values are completely arbitrary, but they enable > // us to display pagination links >- (data.recordsFiltered = 5000), (data.recordsTotal = 5000); >+ ((data.recordsFiltered = 5000), (data.recordsTotal = 5000)); > > return results; > }; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js b/koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js >index 7ece769c332..2628595343f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js >@@ -119,7 +119,7 @@ $(document).ready(function () { > pageSize = results.length; > // These values are completely arbitrary, but they enable > // us to display pagination links >- (data.recordsFiltered = 5000), (data.recordsTotal = 5000); >+ ((data.recordsFiltered = 5000), (data.recordsTotal = 5000)); > > return results; > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41747
:
192287
| 192808