Bugzilla – Attachment 192848 Details for
Bug 40800
TransferArrived needlessly triggers alerts in SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40800: Add unit test for SIP TransferArrived alert fix
3369e44.patch (text/plain), 3.32 KB, created by
Martin Renvoize (ashimema)
on 2026-02-10 08:07:32 UTC
(
hide
)
Description:
Bug 40800: Add unit test for SIP TransferArrived alert fix
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-10 08:07:32 UTC
Size:
3.32 KB
patch
obsolete
>From 3369e4408bb1a9b43ccac3ed5a6433d9539d22a3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 12 Sep 2025 15:18:46 +0100 >Subject: [PATCH] Bug 40800: Add unit test for SIP TransferArrived alert fix > >This test verifies that the TransferArrived message is properly filtered >out during SIP checkin operations to prevent false positive alerts when >an item is successfully checked in at the correct transfer destination. > >The test creates a transfer scenario and confirms that: >1. TransferArrived messages are filtered out of the response >2. No alert_type is set for successful transfer completion >3. Alert flag remains false for accounts with checked_in_ok=1 >4. Transaction is marked as successful > >This validates the fix for the bug where SIP was incorrectly triggering >alerts on successful transfer completion. > >Sponsored-by: OpenFifth <https://openfifth.co.uk> >--- > t/db_dependent/SIP/Transaction.t | 41 +++++++++++++++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index 1d91c693ab5..602b005973b 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -5,7 +5,7 @@ > > use Modern::Perl; > use Test::NoWarnings; >-use Test::More tests => 22; >+use Test::More tests => 23; > use Test::Warn; > > use DateTime; >@@ -1643,4 +1643,43 @@ subtest 'Checkin message' => sub { > is( $circ->{screen_msg}, '', "Checked out item was checked out to the next patron" ); > }; > >+subtest 'TransferArrived should not trigger SIP alert' => sub { >+ plan tests => 4; >+ >+ my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); >+ my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); >+ >+ my $item = $builder->build_sample_item( { library => $library1->branchcode } ); >+ my $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); >+ >+ # Create a transfer from library1 to library2 >+ my $transfer = Koha::Item::Transfer->new( >+ { >+ itemnumber => $item->itemnumber, >+ frombranch => $library1->branchcode, >+ tobranch => $library2->branchcode, >+ datesent => dt_from_string(), >+ reason => 'Manual' >+ } >+ )->store; >+ >+ t::lib::Mocks::mock_userenv( { branchcode => $library2->branchcode, flags => 1 } ); >+ t::lib::Mocks::mock_preference( 'SIP2SortBinMapping', '' ); >+ >+ # Test: Checkin at correct destination with checked_in_ok=1 (should work perfectly) >+ my $ci_transaction = C4::SIP::ILS::Transaction::Checkin->new(); >+ $ci_transaction->item($sip_item); >+ >+ my $account_with_checked_in_ok = { checked_in_ok => 1, sort_bin_mapping => [] }; >+ my $result = $ci_transaction->do_checkin( $library2->branchcode, undef, $account_with_checked_in_ok ); >+ >+ # Key test: TransferArrived message should be filtered out >+ ok( !$result->{messages}->{TransferArrived}, 'TransferArrived message filtered out by fix' ); >+ >+ # Verify no alert is triggered for successful transfer completion >+ is( $ci_transaction->alert_type, undef, 'No alert_type set for successful transfer completion' ); >+ ok( !$ci_transaction->alert, 'Alert flag is false for successful transfer completion' ); >+ is( $ci_transaction->ok, 1, 'Transaction marked as successful' ); >+}; >+ > $schema->storage->txn_rollback; >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40800
:
186385
|
186386
|
192847
| 192848